It looks like the bulk of this module deals directly with Google and that the OG integration could be spun off into a sub-module.

Comments

barnettech’s picture

barnettech commented

Yes someone suggested that, but I don't believe it depends on OG, if it is not installed a conditional clause allows the user to still use the module. Honestly I only have an interest in an OG environment, so don't have the budget from my employer to spend too much time on this use case. That being said, it should absolutely work without OG installed and if you find it doesn't please let me know. I will support this use case for the community.

barnettech’s picture

barnettech commented
Status: Active » Closed (works as designed)

As I said it should be working without OG installed and I don't see that it adds anything to spin it off into it's own module. When the module was reviewed so I could have git write access for this project, it was labelled an optional way to go.

stevector’s picture

stevector
he/him
commented
Status: Closed (works as designed) » Active

I think doing the conditional checks is fine. However listing og as a dependency means that droogle can't be enabled without it: http://drupalcode.org/project/Droogle.git/blob/refs/heads/7.x-1.x:/droog...

barnettech’s picture

barnettech commented

true, I didn't recall doing that. I'll check it out this morning and remove the dependency if it doesn't cause any problems.

barnettech’s picture

barnettech commented
Status: Active » Fixed

Ok this is done for the D7 branch. The dependency is no longer in the .info file.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.