I was having doubts about putting this as a feature request, but I think this is sort of essential. Right now the access permission to administer Facet API Pretty Paths is 'access administration pages'. This is way too broad! I propose to set up a custom permission. I did this in facetapi_pretty_paths.module @line 66 change:
'access arguments' => array('administer facetapi pretty paths'),
and at line 72 add
/**
* Implements hook_permission().
*/
function facetapi_pretty_paths_permission() {
return array(
'administer facetapi pretty paths' => array(
'title' => t('Administer Facet API Pretty Paths'),
),
);
}
Sorry I dont know how to create a patch... And no time today to learn hor to do it! But, this will work and gives you a permission on the permissions page. Sweet!
Comments
Comment #1
dasjohi dagomar,
thanks for pointing this out, i think this is definitely a valid change.
though, i would like to encourage you posting a patch :) i know that at the beginning it is a bit work to get used to it, but from my experience you quickly get fluent with creating patches.
http://drupal.org/node/707484
regards josef
Comment #2
dagomar commentedMy First Patch :)
Sorry for the long delay, I was too busy to look into it. Hope it works!
Comment #3
dasjocool, hope i (others welcome) can review it soon!
Comment #4
dasjopatch applied nicely. i would just recommend using the module's machine name when naming patches (facetapi_pretty_paths_... instead of FacetAPI-PrettyPaths_....).
worked well, thanks dagomar - commited to 7.x-1.x
congratulations on your first commit on being the 5th contributor for facetapi pretty paths so far :)
i have also added some follow up changes.