Google Analytics Social Tracking

welcome,

As installation and usage instructions are quite important for us to review, please take a moment to make your project page follow the tips for a great project page. Also make sure your README.txt follows the guidelines for in-project documentation.

while waiting for an in-depth review of your module you can start out fixing some coding style issues detected by automated tools:
http://ventral.org/pareview/httpgitdrupalorgsandboxsirmusty1570588git

We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.

regards

Hello

Ventral (ventral.org) reports some coding standards issues - http://ventral.org/pareview/httpgitdrupalorgsandboxsirmusty1570588git

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git

I think in your .info requires googleanalytics is wrong - or I can't find a module at drupal.org/project/googleanalytics

Hope this helps.

Pat

I think in your .info requires googleanalytics is wrong - or I can't find a module at drupal.org/project/googleanalytics

Project page is drupal.org/project/google_analytics but module name is googleanalytics. (confusing he?)

Manual review:

1) Creates a 7.x-1.x branch and push your work on it.
2) PHP Code: well commented.
3) JS part is well coded as well. Seems using the drupal mechanisms so that's a good sign.

I put it as Need work because of the branch. This should not be to hard to do.

Fixed some coding standard issues and added a readme file.

This looks like a feature that could go directly into the google analytics module. We prefer collaboration over competition and we want to avoid fragmentation on drupal.org to not confuse users. Please open an issue in the queues of existing projects to join forces and get in contact with the maintainer(s) to discuss this:

http://drupal.org/project/google_analytics
http://drupal.org/project/google_analytics_et

If that fails for whatever reason please get back to us and set this back to "needs review".

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

Did this feature ever make into the google_analytics module as comment 7 suggested?
If not should this issue be re-opened to get this module moved from a sandbox to project?

Added second review bonus link