FAQ Categories field is required.

I've been trying to recreate this, without success.
I have been fiddling with the category handling a little, and may have inadvertently fixed this :-)
Could you provide more details on what exactly you did to make this problem occur?

You are SO right in what you are pointing at. The comparison should of course be '=='! Thank you. Fixed that now.

I suspect your faq category field is set to required on the edit page on admin/structure/types/manage/faq/fields?

If so ('cause this is the only way I am able to recreate the problem you are describing) I'm wondering if the correct fix of that is to require this to be unset, or if this should be forced programmatically off?
I'd be happy to have a small discussion about that.
At one level it does not make sense to have this enabled if only expert can categorise, but does that mean we should fiddle with settings sort of "behind the scenes"?
A middle path would be to indicate the need for switching this off in a message with a clickable link somewhere for the user to easily get to change the settings...

Sten, first let me say how much I appreciate all that you have done with Faq_Ask.

In this case, I think the "middle path" would be the best course. I don't like second guessing the admin, even if it is likely to be a mistake.

Ah, I see your point! Initially I thought this might be a new feature, but I see how this is actually the way it works in D6.
The challenge here is that the form field handling is different. The taxonomy field is not removed from the form as in D6 - only hidden, so if it is set to required, then it will show a warning as you say.
Will need to look into this and see if there is a way to make it NOT required just for the asker form.

Think I've figured it out. The following code should handle this properly and setting the required taxonomy fields to FALSE so that the warning is not appearing when question is posted.

   // Check if only experts can categorize the question.
  if (variable_get('faq_ask_categorize', FALSE)) {
    // Hide all taxonomy fields
    $fields = field_info_instances('node', 'faq');
    foreach ($fields as $name => $properties) {
      if ($properties['display']['default']['module'] == 'taxonomy' && isset($form[$name])) {
       hide($form[$name]);                              // Hide form if it is a taxonomy field
       $form[$name][$language]['#required'] = FALSE;    // If hidden, then do not expect it to be required
      }
    }
  }

When answering, the taxonomy fields are required again.
Fix will be submitted later today and new dev package available tomorrow.

@NancyDru,
Thank you for your comment. I see I am about to catch up on you on the number of commits ;-)
This is really also scratching my own back, and having people really using the module is a motivation boost. I've spent far more time on this than I initially thought.
It seems that my debate proposal might not be needed after all.

Yes, after seeing his use case, which makes a lot of sense, I agree.

Be careful, module maintaining can be addictive. ;-)

The fix will not appear until the may 17th release. (Constitution day of Norway actually :-) )