Posted by kevee on May 10, 2012 at 10:28pm
3 followers
| Project: | Views |
| Version: | 7.x-3.x-dev |
| Component: | Miscellaneous |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs work |
Issue Summary
The views row classes are not lower-cased, which can be a problem if you are using field values like Node: Published, which only displays pre-defined values.
Attached is a simple patch to just strtolower class names, and gives users the option to toggle it on or off.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| views_strtolower_row_class.patch | 1.59 KB | Idle | FAILED: [[SimpleTest]]: [MySQL] 1,420 pass(es), 10 fail(s), and 218 exception(s). | View details | Re-test |
Comments
#1
Changing to needs review.
#2
The last submitted patch, views_strtolower_row_class.patch, failed testing.
#3
+++ b/plugins/views_plugin_style.incundefined@@ -171,6 +174,7 @@ class views_plugin_style extends views_plugin {
+ $options['row_class'] = array('default' => TRUE);
this shold probably be row_class_lower => array('default' => FALSE, 'bool' => TRUE);
#4
@dawehner right, I also changed default to FALSE so it doesn't change default behavior for users who already use row classes in their views.
#5
The last submitted patch, views_row_class_lower-1571352-4.patch, failed testing.