Hi
Thanks for your module, I like it.
I found a bug - (or it is some mistake in my system or text formats?)
when I enable googltube, There is the same movie two times on page (although that movie is only one time in html code as url)
You can see it here:
http://www.somvprahe.sk/blog/miska/berlinske-nebo-v-stokholme
I have Drupal 5.1
Thanks
Igor
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | googtube_breaks_in_a_html_tag_fix.diff | 1.09 KB | markDrupal |
Comments
Comment #1
keizo commentedI can't be certain, but I think the problem might be your filter ordering. I have mine like:
Markdown with SmartyPants
HTML filter
Line break converter
googtube filter
HTML Corrector
URL filter
The main thing is that Googtube has to be after the HTML filter and before the url filter. Let me know if this doesn't work.
Comment #2
igorik commentedHi,
thanks for quick reply
I tried various filter order combinations but there are two movies always.
my current filters are:
AdSense tag (Substitutes an AdSense special tag with an ad)
Gallery2 filter (Allow users to easily reference Gallery2 items from nodes)
HTML Corrector
Inline images (Add images to your posts with Image assist)
URL filter (Turns web and e-mail addresses into clickable links)
Filter is FullHTML format
thanks
Igor
somvprahe.sk
Comment #3
keizo commentedI think if you have it before url filter it should work. Does it still do the same thing on new posts? Perhaps you need to empty the cache tables.
Comment #4
igorik commentedHi
I empty manually tables cache, cache_content, cache_filter, cache_menu, cache_page & cache_views
but the same problem ist still there.
Igor
somvprahe.sk
Comment #5
Carlos Miranda Levy commentedAs explained above, what you are experiencing is not a bug, it´s an issue of inadequately arranged filters.
When I enabled the module myself, I got not 2, but 3 instances of the video.
I followed the instructions for arranging the filters and it works just fine.
Make sure you place the googtube filter after the HTML filter and before the URL filter.
In my case, this is how I have it working properly:
HTML filter
googtube filter
URL filter
Line break converter
Inline images
GMap filter
And make sure that you are doing the arrangement for the filter you are posting. That is, if you are posting with Full HTML, do the arrangement for Full HTML (admin/settings/filters/3/order), which is different than arranging the Filtered HTML filter (admin/settings/filters/1/order) for example.
ps: I changed the issue category from bug report to support request. I did leave it active, though, since I guess many will face the same issue, just as we have.
Comment #6
lashari commentedI was facing same problem with youtube twice display. But I fallow the discussion here and rearrange the input filters. After rearranging filter, I removed cached content from the database and youtube movie output once in the post.
But I see preview of the post on the front page, youtube video was displayed. And after clicking this post full post, there is blank space, no video display.
Preview is showing youtube movie but full post not showing youtube movie, just blank space.
How can I debug this problem
Advance Thanks
Comment #7
kajamohideen commentedI'm also facing the same problem...
Video is posted twice... in preview and full node view... :-(
I have tried all the filter combinations.
HTML Filter
Line Break Converter
HTML Corrector
Googtube Filter
URL Filter
in Filtered HTML Input Format.
How to fix this issue...
Please help me..
Thanks in advance,
Kaja Mohideen
http://www.myistop.com/
Comment #8
pasa commentedDitto
Anyone found a fix/solution/workaround/comprimise? (Video Twice, altering the filter order doesn't sort this issue for me either).
Cheers!
Comment #9
rainer_f commentedThis order
HTML filter
googtube filter
URL filter
Line break converter
Inline images
GMap filter
is defenitely the solution. So, IMHO no bug -> a feature, but a more complicated one :-)
Thanks
Comment #10
kylehase commentedSorting the filters is not a valid workaround. There are at least two cases which the sort workaround fails.
1) If you're using a wysiwyg editor which uses design mode (like whizzywig) then IE will automatically convert the URL into a hyperlinked URL much like the URL filter except in this case URL filtering will be done by IE before the googtube filter.
2) If you want to display a link to a video page but don't actually want to embed the video, googtube will still parse the url in the link tag and embed the video anyway and probably break the link too.
One solution lies in the core URL filter.
If you take a look at the URL filter, you'll see that the regex is designed to handle cases where the URL is already linked so it won't double link. To give you an example, the following could would be skipped by the URL filter but embedded twice by googtube.
<a href="http://www.youtube.com/watch?v=jyt9WbDxVnI">http://www.youtube.com/watch?v=jyt9WbDxVnI</a>Comment #11
markDrupal commentedI think I fixed this for the problem I had when a user submitted a youtube move as the href field in a "A" html tag.
anyways I changed the module to require whitespace or a ">" before the youtube link
here is the new lines of code
Comment #12
yngens commentedi solved this issue by reordering filters, but subscribing for in case this really turns out a bug.
Comment #13
markDrupal commentedReordering didn't work, because if a user enters in a hard link to youtube it will break
you have to reorder the URL filter to trigger after the youtube link.
but if a link already exists before the youtube filter runs it will break, something like
<a href= "youtube.com/video?q=sadfasdfav">click here to view my cat</a>my fix works but it leaves an extra "<" character on most pages visible before the video
on line 74,82 I just added a "><" character to close the previous html tag. I am sure this could be fixed by someone more knowledgeable of REGEX
Comment #14
igorik commentedI can confirm that It is about ordering in filter.
Currently I have this order and it works fine.
HTML filtr
Gallery2 filter
googtube filter
URL filter
Line breaks
Inline images
HTML Purifier
Igorik
http://www.somvprahe.sk
Comment #15
markDrupal commenteddo you allow the "" tag in the HTML filter?
It works fine except for the case when some user adds a link to a youtube video in the form
<a href="http://youtube.com/watch?v=WLuhcfercMg">http://youtube.com/watch?v=WLuhcfercMg</a><a href="http://youtube.com/watch?v=WLuhcfercMg">Watch this video its good!!</a>since the pre_replace starts by looking for a "http://" in this case it will show the video 2 times as well as mess up the theming of that page
if you can say you have the "
<a>" tag allowed in the HTML filter and posting the above link (with the url writen out 2 time) causes no problem in your site, then I guess it could be a problem with my siteComment #16
poveride commentedWhen I had it like this:
HTML filter
Line break converter
URL filter
googtube filter
and I had the same movie twice
I change only order to:
HTML filter
googtube filter
Line break converter
URL filter
and everything is greate!
Comment #17
alexandreracine commentedComment #18
alexandreracine commentedComment #19
WAFishAman commentedHi All
I am encountering the same problem and have rearranged the filters but it still shows 2 videos
Filters are
HTML filter
googtube filter
URL filter
Smileys filter
Line break converter
HTML corrector
Please help :-)
Comment #20
alexandreracine commentedHi WAFishAman, please next time open a new issue. Normally, I would not have seen this post.
For your problem, just like stated on the main page http://drupal.org/project/googtube this should be the order.
HTML filter
googtube filter
Line break converter
URL filter
HTML corrector
Have a nice day.
Comment #21
WAFishAman commentedStill does the same shows up 2 images using the order above
also when viewed with firefox it messes up the page and sends everything to the left. :-(
Comment #22
marlandc commentedI'm having the same problem. Without doing anything with the filter order, in Firefox I get 2 copies of the video, one in the right place and the other to the far left of the page. It works fine in IE. The only filters I have selected are URL filter and Line break converter, in this order:
line break converter
URL filter
If I check HTML filter and put it first, my video goes away entirely.
I see this is for 6.x, my site is at 5.x.
Comment #23
maglio commentedI've encountered the same problem. A solution could be to remove the link from the youtube address video. In any case this module as a lot of bugs.
Comment #24
marlandc commentedI'm beginning to think this happens because the wysiwig editor automatically add object class="youtube"
I have no idea how to stop that from happening, though. I'd really LOVE to be able to post video on my drupal site, so I hope that someone has a solution for this.
Thanks much,
Cheryl
Comment #25
marlandc commentedadditional comment: changing the filter order had no effect at all.
I tested my theory about YouTube - I have an Animoto video - when I pasted in the javascript for the video - no problems. It's posted fine.
If anyone knows how to turn off the automatic YouTube CSS (I can't find it) please respond.
Thanks much, Cheryl
Comment #26
alexandreracine commentedHa, so you are using a wysiwig editor. Turn it off, and add a new node with a youtube link. If that work's you'll be sure that it is the wysiwig editor. I don't use one personnaly since it does screw up in some cases. You could ask in the forums for questions about the editor and if you find something, just add a link to the forum post here. Thanks.
Comment #27
marlandc commentedThank you!!! That took care of it. The wysiwyg editor was the problem. All I did was click the "disable editor" under the post. I'd never even noticed it before. Again, thanks so much.
Comment #28
funatweb commentedFinal Solution:
Configure the filtered html (for which u hav enabled gogtube) : remove ">a<" tag from text box under "Allowed HTML tags".
That's all.