Closed (won't fix)
Project:
Comment RSS
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
6 Jul 2007 at 09:02 UTC
Updated:
14 Jul 2007 at 22:53 UTC
From http://drupal.org/node/156666
NOTE: this patch is dependent on the patch in the above issue. That issue above creates an admin menu for CommentRSS. The patch here adds to that menu.
By default, CommentRSS adds a teaser to the comments feed (unless you have "full text" or "title only" enabled in your RSS settings; this bug is addressed in http://drupal.org/node/157244). It is mentioned in issue #156666 cited above that this is non-standard. This patch adds a checkbox to the menu item that allows you to enable or disable the teaser in the feed.
| Comment | File | Size | Author |
|---|---|---|---|
| commentrss.module.HEAD_.includeteaser.r0.patch | 3.4 KB | gnassar |
Comments
Comment #1
tangent commentedI already commented in issue 156666 but I should have commented here.
A feed is not a static page of content but is a stream of updated content. Including an "entry" which is not updated content breaks this rule. It could be argued that adding the source node as the first "comment" entry would be appropriate, if there are less entries than the maximum and the source node disappears when the queue fills. This is especially arguable in the case of forum threads.
Never the less, I recommend "wont-fix" for this issue and removing the source node from the feed as I did in the patch in issue 156666.
Comment #2
gnassar commentedNo worries.
As I've mentioned in the previous conversation, I wholeheartedly agree that a teaser doesn't belong in a comment feed. That being said, it was included for a reason, that ostensibly being that the module creator wants it there. Otherwise, why would anyone have gone to the trouble of adding that feature? It's not like any other functionality is dependent on it; a "patch" to remove it effectively just removes the 25 or so lines that were added to allow for that teaser.
Making it optional allows for current functionality to remain unaffected, for the owner and whoever else prefers that to be there, and for the current users of the module that expect it there, while allowing for those who want their comment feed "pure" to have it as such.
Comment #3
tangent commentedThis is no longer an issue. Node teasers have been removed from the feed.
http://drupal.org/node/157613