Currently when we verify a platform, we bootstrap the Drupal root. But even if that fails (e.g if the root level dir is not chmod 755 and can't be entered), we keep going and try and check the sites dir is writable, scan for packages, find Drupal version, etc etc.

This results in various ugly errors in the Verify task:

The directory /var/aegir/platforms/foo does not contain a valid Drupal installation
Drupal sites directory /var/aegir/platforms/foo/sites is not writable by the provisioning script
Use of undefined constant VERSION - assumed 'VERSION' verify.provision.inc:75
This platform is running drupal VERSION
Use of undefined constant VERSION - assumed 'VERSION' provision_drupal.drush.inc:523
Found install profile default
Found install profile hostmaster
Command dispatch complete

Note how it seems we 'find' the hostmaster profile - it has probably reverted to scanning the Hostmaster platform itself!

We should immediately return FALSE if we couldn't bootstrap the relevant platform.

Comments

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Fixed

Fixed in

6.x-2.x http://drupalcode.org/project/provision.git/commit/a0a16b2
6.x-1.x http://drupalcode.org/project/provision.git/commit/9c2900c

Anonymous’s picture

Anonymous (not verified) commented

Note that this will allow a platform to be automatically locked (so that it is not a viable candidate for installing or migrating sites onto it) in this rollback hook: #1081562: Unverified platforms available for site clone

... which depends on rollback hooks actually working in Hosting again ( see #1573162: Drush hosting_task_%task_rollback() invocations are never executed )

phew!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit a0a16b2 on dev-drupal-8, 6.x-2.x, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x by mig5: 
    Issue #1573182 - Verifying a platform should abort if it can't be...