See image for the bad link output. Disabling Fences fixes it. If I re-enable fences I have to go back to the field and save it for it to happen again.

CommentFileSizeAuthor
#11 Screen shot 2012-11-16 at 1.12.57 PM.png58.54 KBericgsmith
#1 link-junk-fences.jpg7.31 KBAnonymous (not verified)

Comments

Anonymous’s picture

StatusFileSize
new7.31 KB
Anonymous’s picture

The case is when using Views Slideshow to link an image to a Link field, if that helps.

johnalbin’s picture

Status: Active » Postponed (maintainer needs more info)
Anonymous’s picture

Follow the tutorial linked from Views Slideshow at http://www.brightwebsitedesign.com/how-to-install-views-slideshow-module...

When you get to "Output this field as a link" making the View, Fences breaks the link (displaying something like what I attached originally).

Hope that helps.

johnalbin’s picture

Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)

The tutorial is very long. Please provide the most simple number of steps to reproduce the problem. Again, please read all of http://drupal.org/node/73179#issue-details

Also, the image you attached originally is complete rubbish. It is a close cropped image of something, but I can't tell what.

Anonymous’s picture

John,
You don't have to fix the issue. I just won't use the module.

Have a good day!

johnalbin’s picture

You don't have to fix the issue.

I didn't close the issue because I don't want to fix the bug.

Right now there isn't even enough information for others to help debug what's going on.

Specifically, I scanned through that tutorial to find where "Check Output this field as a link" occurs and it is in the line “Rewrite Results: Check Output this field as a link”.

But if you check the rewrite results option, then Views rewrites the field directly and the Fences module doesn't get used at all for that View. Fences only gets used in Views if the row style is content or rendered entity or fields (with the row style option "Provide default field wrapper elements").

I just won't use the module.

The module works very well. I would love for all its minor bugs (which I haven't experienced) get fixed too! But you have to help me to help others.

Right now it appears the bug you are describing can't be caused by Fences. But I can only guess based on the minimal information you provided.

ruichen’s picture

Hi,

I got same issue:

I check "Output this field as a link" in the view configuration:

I got this:

mypath/?q=sub-product/LED%20Drivers%20

I think the reason is the title being clicked as a link, with space in between, how can I fix it

the title is "LED Drivers"

how can
mypath/?q=sub-product/LED-Drivers

What should I do?

Thanks,

ruichen

Mark_L6n’s picture

I can confirm the problem. Glad I found this page--I had spent many hours tracking this down.
To reproduce, create a Views Slideshow using a Content Type that contains Image and Link (drupal.org/project/link) fields, and make the Image clickable with the link, much as the tutorial in #4 does.
in View under Format/Show, choose 'Fields'
Link Field: Must come before Image field. Check 'Exclude from Display'. Formatter: 'URL, as link'.
Image Field: In 'Rewrite Results', check 'Output this field as link' and check 'Replacement Patterns' further down for usage. Essentially put the machine name of the link field in square brackets, eg: [field_image_link]

Without fences installed, a link to subpage 'people' looks like: http://path/to/drupal/people
With fences installed, the link looks like http://path/to/drupal/%0A%20%20%0A%20%20%20%20http%3A//path/to/drupal/people%20%20%0A

I tried wrapping the link field 'no markup', 'div' , 'p', 'address', 'span' and 'ul' under Fences, all with the same problem.

Mark_L6n’s picture

Status: Closed (cannot reproduce) » Active

Modifying status to -active-.

ericgsmith’s picture

StatusFileSize
new58.54 KB

Hi all.

This is not a bug in the module. This is an error in your view setup.

Make sure your link field is not using a field template or any custom wrappers. Set the output as url as plain text.

Think of it this way: the field is not outputted and is simply used as a token of the image field. By wrapping it in a field template you are attempting to put <span>http://....</span> inside an a tag.

Set it as URL plain text with no template or wrappers. This will input the actual URL into the image's <a> tag.

matsbla’s picture

Eureka! This fixed it for me. Thanks a lot :-)

plach’s picture

Category: bug » support
Priority: Major » Normal
Status: Active » Fixed

Yup, actually #11 is the correct fix.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.