The module requires media so it should be listed as a requirement.

I will attach a patch shortly

CommentFileSizeAuthor
#1 upload_nodes-1574702-1.patch291 bytesmicheas

Comments

micheas’s picture

Status: Active » Needs review
StatusFileSize
new291 bytes

Here is the patch.

Thanks for the great module.

pyrollo’s picture

Status: Needs review » Fixed

Thanks a lot for this issue.

This is not that simple. Actually, upload_nodes should not depend on media but here is what happened :

There were two file_uri_to_object functions. One in plupload intergration module, one in media module.

The one from plupload integration was a bit less advanced than the one from media. As I did not want to depend from media module, I did a copy of file_uri_to_object named _upload_nodes_file_uri_to_object. Unfortunately, upload_nodes_upload_form_submit was still using file_uri_to_object function from plupload integration that got recentely renamed (see #1240654: Use a proper namespace for file_uri_to_object()) in order to avoid conflict with media module.

I think that upload_node should not depend on media module only for that function. And I also think that this function should not be in a module but in drupal core. I hope there will be a replacement function in the future but meanwhile, I just changed upload_node code so it uses its own function instead of the one from media module (commited).

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.