Following the recent development list discussions, I've been thinking it'd be good to add some extra flags to CNR and CNW (or additional flags, in which case that'd be a feature request againt project.module).

Sometimes patches just need benchmarks:

http://drupal.org/node/148849
http://drupal.org/node/106559

are examples where this has, or will be the case. There's plenty of others as well.

The idea being that along with "concept needs feedback" which is a great idea - there might be a way for the patch statuses to provide more description as to what kind of review (or work) they need.

Comments

Frando’s picture

Frando commented

I think this is a good idea. If I create a benchmark setup, I usually don't bother to run two more patches. So it would be great to be able to find them easily.

catch’s picture

catch
he/him
Primary language English
commented

Thanks for the feedback, that was my thinking behind it.

Also maybe:
needs user interface review (cf. http://drupal.org/node/147143 )

- but this might be better done as checkboxes/select which add information to the "needs review/needs work" status, which'd be a different thing entirely.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

I agree completely with a "needs benchmark" indicator of some sort.

While list that could be multi-selected (needs benchmark, needs UI review, needs {more criteria} review) would probably be best, I think the simple case is the most likely which is that a patch needs either a benchmark OR a UI review, but rarely more than one at a time.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Closed (won't fix)

We now have issue tags. No longer applies.