Add check for author->mail in function _comment_notify_mailalert($comment)
Empty author->mail causes Error sending e-mail

CommentFileSizeAuthor
#3 1576878_no_anonymous_notification.patch1.37 KBgreggles

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Makes sense, maybe we should look for an empty mail. That said...how did anonymous get subscribed to a notification?

dusov’s picture

dusov commented

admin/config/people/comment_notify
Check-box "Subscribe users to their node follow-up notification emails by default"
Thus, anonymous (who create node) get subscribed to a notification

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Active » Needs review
StatusFileSize
new 1576878_no_anonymous_notification.patch1.37 KB

How about this, which adds some comments.

Status: Needs review » Needs work

The last submitted patch, 1576878_no_anonymous_notification.patch, failed testing.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Version: 7.x-1.0 » 7.x-1.x-dev
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs work » Needs review

#3: 1576878_no_anonymous_notification.patch queued for re-testing.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Fixed

Now committed http://drupalcode.org/project/comment_notify.git/commit/b1a8cf3

Thanks for pointing this out, dusov.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.