Attached is a first cut at the 6.x upgrade. It also includes some coding style fixes. This upgrade patch was assisted by the coder 6.x upgrade review. I left several @TODO comments in the code, where I wasn't sure what to do.

Comments

douggreen’s picture

dww’s picture

Status: Needs work » Postponed

Thanks for getting this started. However, 2 big problems. ;)

1) We don't even have a 5.x-1.0 release yet (it's a long story), so this is premature.

2) Please do NOT include code style changes and API upgrade changes in the same patch. Ever. ;) See http://drupal.org/node/154190. So, if you want to be truly helpful, you'd submit a *separate* issue for the code-style changes, and include patches for HEAD (5.x-0.x-dev) DRUPAL-4-7--2 and DRUPAL-4-7. Then, the upgrade patch can focus on API changes, and not code style.

Thanks!
-Derek

douggreen’s picture

I was really responding to your email on the devel list about lamenting the 6.x upgrade. I can resubmit without the coding style changes, because you're right there and I got overzealous, but in defense, they're all little things like extra or missing spaces. But before I recreate without the style changes, I get that I did this off of the right branch (HEAD), but also hear that you think it's premature. Do you want me to wait?

dww’s picture

Thanks for trying to help, I didn't mean to discourage you...

What would be helpful in the short term is what I said in my previous comment: a patch for *just* the code-style changes for HEAD, DRUPAL-4-7--2 and DRUPAL-4-7.

Medium term, I'm going to spend an hour or 2 and get a 5.x-1.0 release ready, and create a DRUPAL-5 branch. After that, I'll set this back to "needs work", at which point a patch for *just* the D6 API changes would be most welcome.

Sound good?

Thanks,
-Derek

gerhard killesreiter’s picture

Status: Postponed » Active

I think it's time to re-activate this issue.

hunmonk’s picture

please see http://groups.drupal.org/node/6180 for the full project road map which will get us to 6.x intelligently.

there are other things to handle before we can start the actual porting of the code.

dww’s picture

Status: Active » Postponed

Right. This issue, as titled, can't start until more things on http://groups.drupal.org/node/6180 are done, which is why we left this postponed.

aclight’s picture

Title: Upgrade to 6.x » Upgrade project issue to Drupal 6.x
Status: Postponed » Needs work

Yesterday hunmonk created a project issue 5.x-2.2 release, and so by my understanding we're ready to start porting pi to Drupal 6.x. I've updated the project* roadmap at http://groups.drupal.org/node/6180 a bit to reflect the current state of affairs.

We still need to create another release for the project module before we start porting it, and it makes sense to work on the project module port before the project issue module port, but they can be done mostly in parallel.

aclight’s picture

Version: 5.x-2.x-dev » 6.x-1.x-dev

Bumping version.

bdragon’s picture

Is there an external repo where this is being worked on at the moment, or is it on hold while aclight works on the project.module port?

aclight’s picture

If i'm the first to start working on a port, I'll likely create a svn repository on devguard just like I've done for the project port.

However, I don't believe anyone has started the pi port yet for a few reasons:
1. Project port isn't finished yet.
2. Comment upload port hasn't been finished yet (AFAIK).

One thing that someone could do that would be really helpful to me would be to port the project_issue.js file for D6. I have very little experience with javascript, and while it would probably take only a few minutes for someone who knows what he/she is doing to port the javascript code, it would take me a lot longer.

hillaryneaf’s picture

subscribing..

arhak’s picture

subscribing

Anonymous’s picture

subscribing

sjlacroix’s picture

subscribing... Any ETA so far?

pauline_perren’s picture

subscribing

chasz’s picture

+1

aclight’s picture

@sjlacroix: Nope, not really. It hasn't even been started yet as far as I know.

unclejens’s picture

subscribing

livingegg’s picture

subscribing. Any word whether project issue will be able to attach to non-project nodes?

dww’s picture

@livingegg: We're almost certainly not going to be adding any new features for the 6.x-1.0 release except extensive views integration. Attaching to non-project nodes would happen in a 6.x-2.* series.

Brigadier’s picture

subscribing

fuzzy_texan’s picture

Subscribing

hbfkf’s picture

subscribing

TotalMeltdown’s picture

subscribing

dww’s picture

Assigned: Unassigned » dww
Priority: Normal » Critical
Status: Needs work » Needs review
Issue tags: +drupal.org upgrade
StatusFileSize
new98.8 KB

Given my recent commits in HEAD, here's an initial patch to port to D6. There are definitely some things that are still broken, but this is a big start...

dww’s picture

Status: Needs review » Active

Committed #26 to HEAD. Back to active since there are a ton of things still broken, although my preference is going to be to handle the followup problems in separate issues.

tms8707056’s picture

subscribing

andreiashu’s picture

subscribing

jonmc12’s picture

subscribing

netaustin’s picture

StatusFileSize
new4.25 KB

Post this FAPI fixes for s.d.o, please.

dww’s picture

Reviewed, tested and committed #32 to HEAD. Thanks.

dww’s picture

Status: Postponed » Fixed

This is basically now done. There are still a few minor things to tweak, but I think we can call this fixed. Obviously there's still work to do before an official 6.x-1.0 release, but we should work that out in other issues, not here.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

sebzur’s picture

subscribing

quinn-2’s picture

this seems to be fixed, but i'm not sure where to find the patch or a patched/fixed version. anybody point me in the right direction?

aclight’s picture