Upgrade project issue to Drupal 6.x

douggreen - July 8, 2007 - 15:05
Project:Project issue tracking
Version:6.x-1.x-dev
Component:Miscellaneous
Category:task
Priority:normal
Assigned:Unassigned
Status:patch (code needs work)
Description

Attached is a first cut at the 6.x upgrade. It also includes some coding style fixes. This upgrade patch was assisted by the coder 6.x upgrade review. I left several @TODO comments in the code, where I wasn't sure what to do.

AttachmentSize
project_issue_6x.patch37.39 KB

#1

douggreen - July 8, 2007 - 15:09

#2

dww - July 8, 2007 - 15:14
Status:patch (code needs work)» postponed

Thanks for getting this started. However, 2 big problems. ;)

1) We don't even have a 5.x-1.0 release yet (it's a long story), so this is premature.

2) Please do NOT include code style changes and API upgrade changes in the same patch. Ever. ;) See http://drupal.org/node/154190. So, if you want to be truly helpful, you'd submit a *separate* issue for the code-style changes, and include patches for HEAD (5.x-0.x-dev) DRUPAL-4-7--2 and DRUPAL-4-7. Then, the upgrade patch can focus on API changes, and not code style.

Thanks!
-Derek

#3

douggreen - July 8, 2007 - 21:06

I was really responding to your email on the devel list about lamenting the 6.x upgrade. I can resubmit without the coding style changes, because you're right there and I got overzealous, but in defense, they're all little things like extra or missing spaces. But before I recreate without the style changes, I get that I did this off of the right branch (HEAD), but also hear that you think it's premature. Do you want me to wait?

#4

dww - July 8, 2007 - 23:15

Thanks for trying to help, I didn't mean to discourage you...

What would be helpful in the short term is what I said in my previous comment: a patch for *just* the code-style changes for HEAD, DRUPAL-4-7--2 and DRUPAL-4-7.

Medium term, I'm going to spend an hour or 2 and get a 5.x-1.0 release ready, and create a DRUPAL-5 branch. After that, I'll set this back to "needs work", at which point a patch for *just* the D6 API changes would be most welcome.

Sound good?

Thanks,
-Derek

#5

Gerhard Killesreiter - December 29, 2007 - 17:16
Status:postponed» active

I think it's time to re-activate this issue.

#6

hunmonk - December 30, 2007 - 03:14

please see http://groups.drupal.org/node/6180 for the full project road map which will get us to 6.x intelligently.

there are other things to handle before we can start the actual porting of the code.

#7

dww - January 6, 2008 - 18:47
Status:active» postponed

Right. This issue, as titled, can't start until more things on http://groups.drupal.org/node/6180 are done, which is why we left this postponed.

#8

aclight - April 21, 2008 - 11:24
Title:Upgrade to 6.x» Upgrade project issue to Drupal 6.x
Status:postponed» patch (code needs work)

Yesterday hunmonk created a project issue 5.x-2.2 release, and so by my understanding we're ready to start porting pi to Drupal 6.x. I've updated the project* roadmap at http://groups.drupal.org/node/6180 a bit to reflect the current state of affairs.

We still need to create another release for the project module before we start porting it, and it makes sense to work on the project module port before the project issue module port, but they can be done mostly in parallel.

#9

aclight - April 26, 2008 - 21:20
Version:5.x-2.x-dev» 6.x-1.x-dev

Bumping version.

#10

bdragon - July 22, 2008 - 17:45

Is there an external repo where this is being worked on at the moment, or is it on hold while aclight works on the project.module port?

#11

aclight - July 23, 2008 - 13:52

If i'm the first to start working on a port, I'll likely create a svn repository on devguard just like I've done for the project port.

However, I don't believe anyone has started the pi port yet for a few reasons:
1. Project port isn't finished yet.
2. Comment upload port hasn't been finished yet (AFAIK).

One thing that someone could do that would be really helpful to me would be to port the project_issue.js file for D6. I have very little experience with javascript, and while it would probably take only a few minutes for someone who knows what he/she is doing to port the javascript code, it would take me a lot longer.

#12

nektir - September 4, 2008 - 16:29

subscribing..

#13

arhak - September 13, 2008 - 20:36

subscribing

#14

zvilikestv - October 5, 2008 - 04:38

subscribing

#15

sjlacroix - October 8, 2008 - 00:28

subscribing... Any ETA so far?

#16

pauline_perren - October 8, 2008 - 06:37

subscribing

#17

chasz - October 8, 2008 - 10:41

+1

#18

aclight - October 8, 2008 - 10:50

@sjlacroix: Nope, not really. It hasn't even been started yet as far as I know.

 
 

Drupal is a registered trademark of Dries Buytaert.