Closed (fixed)
Project:
Project issue tracking
Version:
6.x-1.x-dev
Component:
Miscellaneous
Priority:
Critical
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
8 Jul 2007 at 15:05 UTC
Updated:
25 Feb 2009 at 00:22 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
douggreen commentedSee also project 6,x upgrade.
Comment #2
dwwThanks for getting this started. However, 2 big problems. ;)
1) We don't even have a 5.x-1.0 release yet (it's a long story), so this is premature.
2) Please do NOT include code style changes and API upgrade changes in the same patch. Ever. ;) See http://drupal.org/node/154190. So, if you want to be truly helpful, you'd submit a *separate* issue for the code-style changes, and include patches for HEAD (5.x-0.x-dev) DRUPAL-4-7--2 and DRUPAL-4-7. Then, the upgrade patch can focus on API changes, and not code style.
Thanks!
-Derek
Comment #3
douggreen commentedI was really responding to your email on the devel list about lamenting the 6.x upgrade. I can resubmit without the coding style changes, because you're right there and I got overzealous, but in defense, they're all little things like extra or missing spaces. But before I recreate without the style changes, I get that I did this off of the right branch (HEAD), but also hear that you think it's premature. Do you want me to wait?
Comment #4
dwwThanks for trying to help, I didn't mean to discourage you...
What would be helpful in the short term is what I said in my previous comment: a patch for *just* the code-style changes for HEAD, DRUPAL-4-7--2 and DRUPAL-4-7.
Medium term, I'm going to spend an hour or 2 and get a 5.x-1.0 release ready, and create a DRUPAL-5 branch. After that, I'll set this back to "needs work", at which point a patch for *just* the D6 API changes would be most welcome.
Sound good?
Thanks,
-Derek
Comment #5
gerhard killesreiter commentedI think it's time to re-activate this issue.
Comment #6
hunmonk commentedplease see http://groups.drupal.org/node/6180 for the full project road map which will get us to 6.x intelligently.
there are other things to handle before we can start the actual porting of the code.
Comment #7
dwwRight. This issue, as titled, can't start until more things on http://groups.drupal.org/node/6180 are done, which is why we left this postponed.
Comment #8
aclight commentedYesterday hunmonk created a project issue 5.x-2.2 release, and so by my understanding we're ready to start porting pi to Drupal 6.x. I've updated the project* roadmap at http://groups.drupal.org/node/6180 a bit to reflect the current state of affairs.
We still need to create another release for the project module before we start porting it, and it makes sense to work on the project module port before the project issue module port, but they can be done mostly in parallel.
Comment #9
aclight commentedBumping version.
Comment #10
bdragon commentedIs there an external repo where this is being worked on at the moment, or is it on hold while aclight works on the project.module port?
Comment #11
aclight commentedIf i'm the first to start working on a port, I'll likely create a svn repository on devguard just like I've done for the project port.
However, I don't believe anyone has started the pi port yet for a few reasons:
1. Project port isn't finished yet.
2. Comment upload port hasn't been finished yet (AFAIK).
One thing that someone could do that would be really helpful to me would be to port the project_issue.js file for D6. I have very little experience with javascript, and while it would probably take only a few minutes for someone who knows what he/she is doing to port the javascript code, it would take me a lot longer.
Comment #12
hillaryneaf commentedsubscribing..
Comment #13
arhak commentedsubscribing
Comment #14
Anonymous (not verified) commentedsubscribing
Comment #15
sjlacroix commentedsubscribing... Any ETA so far?
Comment #16
pauline_perren commentedsubscribing
Comment #17
chasz commented+1
Comment #18
aclight commented@sjlacroix: Nope, not really. It hasn't even been started yet as far as I know.
Comment #19
unclejens commentedsubscribing
Comment #20
livingegg commentedsubscribing. Any word whether project issue will be able to attach to non-project nodes?
Comment #21
dww@livingegg: We're almost certainly not going to be adding any new features for the 6.x-1.0 release except extensive views integration. Attaching to non-project nodes would happen in a 6.x-2.* series.
Comment #22
Brigadier commentedsubscribing
Comment #23
fuzzy_texan commentedSubscribing
Comment #24
hbfkf commentedsubscribing
Comment #25
TotalMeltdown commentedsubscribing
Comment #26
dwwGiven my recent commits in HEAD, here's an initial patch to port to D6. There are definitely some things that are still broken, but this is a big start...
Comment #27
dwwCommitted #26 to HEAD. Back to active since there are a ton of things still broken, although my preference is going to be to handle the followup problems in separate issues.
Comment #28
dwwRelated issues:
#361649: Issue comments broken in D6 HEAD
#361650: Port project_issue to D6 version of comment_upload
#361651: Port project_issue to use the D6 drupal_mail()
#361652: Document the project_issue schema in project_issue.install
Comment #29
tms8707056 commentedsubscribing
Comment #30
andreiashu commentedsubscribing
Comment #31
jonmc12 commentedsubscribing
Comment #32
netaustin commentedPost this FAPI fixes for s.d.o, please.
Comment #33
dwwReviewed, tested and committed #32 to HEAD. Thanks.
Comment #34
dwwThis is basically now done. There are still a few minor things to tweak, but I think we can call this fixed. Obviously there's still work to do before an official 6.x-1.0 release, but we should work that out in other issues, not here.
Comment #36
sebzur commentedsubscribing
Comment #37
quinn-2 commentedthis seems to be fixed, but i'm not sure where to find the patch or a patched/fixed version. anybody point me in the right direction?
Comment #38
aclight commented@qunn: http://drupal.org/node/75232/release?api_version[]=87