Upgrade project issue to Drupal 6.x
douggreen - July 8, 2007 - 15:05
| Project: | Project issue tracking |
| Version: | 6.x-1.x-dev |
| Component: | Miscellaneous |
| Category: | task |
| Priority: | critical |
| Assigned: | dww |
| Status: | closed |
| Issue tags: | drupal.org upgrade |
Description
Attached is a first cut at the 6.x upgrade. It also includes some coding style fixes. This upgrade patch was assisted by the coder 6.x upgrade review. I left several @TODO comments in the code, where I wasn't sure what to do.
| Attachment | Size |
|---|---|
| project_issue_6x.patch | 37.39 KB |
#1
See also project 6,x upgrade.
#2
Thanks for getting this started. However, 2 big problems. ;)
1) We don't even have a 5.x-1.0 release yet (it's a long story), so this is premature.
2) Please do NOT include code style changes and API upgrade changes in the same patch. Ever. ;) See http://drupal.org/node/154190. So, if you want to be truly helpful, you'd submit a *separate* issue for the code-style changes, and include patches for HEAD (5.x-0.x-dev) DRUPAL-4-7--2 and DRUPAL-4-7. Then, the upgrade patch can focus on API changes, and not code style.
Thanks!
-Derek
#3
I was really responding to your email on the devel list about lamenting the 6.x upgrade. I can resubmit without the coding style changes, because you're right there and I got overzealous, but in defense, they're all little things like extra or missing spaces. But before I recreate without the style changes, I get that I did this off of the right branch (HEAD), but also hear that you think it's premature. Do you want me to wait?
#4
Thanks for trying to help, I didn't mean to discourage you...
What would be helpful in the short term is what I said in my previous comment: a patch for *just* the code-style changes for HEAD, DRUPAL-4-7--2 and DRUPAL-4-7.
Medium term, I'm going to spend an hour or 2 and get a 5.x-1.0 release ready, and create a DRUPAL-5 branch. After that, I'll set this back to "needs work", at which point a patch for *just* the D6 API changes would be most welcome.
Sound good?
Thanks,
-Derek
#5
I think it's time to re-activate this issue.
#6
please see http://groups.drupal.org/node/6180 for the full project road map which will get us to 6.x intelligently.
there are other things to handle before we can start the actual porting of the code.
#7
Right. This issue, as titled, can't start until more things on http://groups.drupal.org/node/6180 are done, which is why we left this postponed.
#8
Yesterday hunmonk created a project issue 5.x-2.2 release, and so by my understanding we're ready to start porting pi to Drupal 6.x. I've updated the project* roadmap at http://groups.drupal.org/node/6180 a bit to reflect the current state of affairs.
We still need to create another release for the project module before we start porting it, and it makes sense to work on the project module port before the project issue module port, but they can be done mostly in parallel.
#9
Bumping version.
#10
Is there an external repo where this is being worked on at the moment, or is it on hold while aclight works on the project.module port?
#11
If i'm the first to start working on a port, I'll likely create a svn repository on devguard just like I've done for the project port.
However, I don't believe anyone has started the pi port yet for a few reasons:
1. Project port isn't finished yet.
2. Comment upload port hasn't been finished yet (AFAIK).
One thing that someone could do that would be really helpful to me would be to port the project_issue.js file for D6. I have very little experience with javascript, and while it would probably take only a few minutes for someone who knows what he/she is doing to port the javascript code, it would take me a lot longer.
#12
subscribing..
#13
subscribing
#14
subscribing
#15
subscribing... Any ETA so far?
#16
subscribing
#17
+1
#18
@sjlacroix: Nope, not really. It hasn't even been started yet as far as I know.
#19
subscribing
#20
subscribing. Any word whether project issue will be able to attach to non-project nodes?
#21
@livingegg: We're almost certainly not going to be adding any new features for the 6.x-1.0 release except extensive views integration. Attaching to non-project nodes would happen in a 6.x-2.* series.
#22
subscribing
#23
Subscribing
#24
subscribing
#25
subscribing
#26
Given my recent commits in HEAD, here's an initial patch to port to D6. There are definitely some things that are still broken, but this is a big start...
#27
Committed #26 to HEAD. Back to active since there are a ton of things still broken, although my preference is going to be to handle the followup problems in separate issues.
#28
Related issues:
#361649: Issue comments broken in D6 HEAD
#361650: Port project_issue to D6 version of comment_upload
#361651: Port project_issue to use the D6 drupal_mail()
#361652: Document the project_issue schema in project_issue.install
#29
subscribing
#30
subscribing
#31
subscribing
#32
Post this FAPI fixes for s.d.o, please.
#33
Reviewed, tested and committed #32 to HEAD. Thanks.
#34
This is basically now done. There are still a few minor things to tweak, but I think we can call this fixed. Obviously there's still work to do before an official 6.x-1.0 release, but we should work that out in other issues, not here.
#35
Automatically closed -- issue fixed for 2 weeks with no activity.
#36
subscribing
#37
this seems to be fixed, but i'm not sure where to find the patch or a patched/fixed version. anybody point me in the right direction?
#38
@qunn: http://drupal.org/node/75232/release?api_version[]=87