The node_feed() function allows modules to add namespaces to an RSS feed. However, they are added with array_merge in the loop while processing each node in the feed so the same namespace is added multiple times. The reason is that the namespaces array does not use keys so identical namespaces are added with unique integer keys. The attached bug fixes this. I highly recommend allowing this to backport to D5 as well.

I discovered this when I added the wfw namespace with changes to commentrss.module.

CommentFileSizeAuthor
node_feed_0.patch1.13 KBtangent

Comments

tangent’s picture

tangent commented

Can someone please comment on this? It's a very minimal patch.

dries’s picture

dries commented
Status: Needs review » Needs work

I've committed this to CVS HEAD. As this is a small API change, I suggest you document this in the upgrade instructions.

Thanks tangent.

tangent’s picture

tangent commented
Status: Needs work » Fixed

I've noted the change as a comment here, as that's the only ability I have. Hopefully that's the documentation you are referring to.
http://drupal.org/node/114774#comment-252463

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)