Hello,

There is a small issue when searching for a username in autocomplete.
Only usernames that are starting with the keyword are returned.

Here's is a patch that will return usernames that contains the keyword.

CommentFileSizeAuthor
#15 masquerade-1577496-14-username-contains.patch575 bytesjustcaldwell
#7 masquerade-autocomplete.patch747 bytesludo.r
#3 masquerade-autocomplete.patch747 bytesludo.r
masquerade-autocomplete.patch745 bytesludo.r

Issue fork masquerade-1577496

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ludo.r’s picture

ludo.r
Location Brussels
commented
Title: Search automcomplete » Search autocomplete
ludo.r’s picture

ludo.r
Location Brussels
commented
Title: Search autocomplete » Username search autocomplete
ludo.r’s picture

ludo.r
Location Brussels
commented
StatusFileSize
new masquerade-autocomplete.patch747 bytes

Sorry,

Previous patch doesn't work as expected.
Try this one instead :

andypost’s picture

andypost
he/him
Primary language Russian
commented
Version: 6.x-1.7 » 6.x-1.x-dev
Status: Active » Needs review

Your patch changes search to starting with... as for me this makes no sense because this regression from current functionaly.

ludo.r’s picture

ludo.r
Location Brussels
commented

I'm not sure to understand what you say.

This patch allows searching usernames that contain the keyword rather than starting with the keyword.

Let's say we have a john.smith username.

Before, if I typed smith, I found nothing.
With this patch, you would find john.smith.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Needs work 
+++ b\masquerade.module
@@ -555,7 +555,7 @@
-  $result = db_query_range("SELECT u.name FROM {users} u WHERE LOWER(u.name) LIKE LOWER('%%%s%%')", $string, 0, 10);
+  $result = db_query_range("SELECT u.name FROM {users} u WHERE LOWER(u.name) LIKE LOWER('%s%%')", $string, 0, 10);

but your batch suggests %s%% whick means starting with

ludo.r’s picture

ludo.r
Location Brussels
commented
StatusFileSize
new masquerade-autocomplete.patch747 bytes

Oh, sorry, my mistake.
I inverted the two files.

Here it is :

andypost’s picture

andypost
he/him
Primary language Russian
commented
Title: Username search autocomplete » Change Username search autocomplete to - contains string
Status: Needs work » Needs review

Re-titled and makes sense so let's get more reviews

andypost’s picture

andypost
he/him
Primary language Russian
commented
Category: bug » feature

this change should be ported to 7.x first and require review of other mainteiners

deekayen’s picture

deekayen commented
Status: Needs review » Needs work

I'll commit stuff that for 7 with no 6 patch, but not the other way around.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
Status: Needs work » Closed (outdated)

I am closing this feature request, as Drupal 6 is no longer supported. Please re-open it if you would like the feature implemented in the Drupal 7 or 8 version of the module.

justcaldwell’s picture

justcaldwell
he/him
Primary language English
Location Austin, Texas
commented
Version: 6.x-1.x-dev » 8.x-2.x-dev
Status: Closed (outdated) » Active

This would be a small but nice UX improvement.

justcaldwell opened merge request !22

justcaldwell’s picture

justcaldwell
he/him
Primary language English
Location Austin, Texas
commented
Status: Active » Needs review
justcaldwell’s picture

justcaldwell
he/him
Primary language English
Location Austin, Texas
commented
StatusFileSize
new masquerade-1577496-14-username-contains.patch575 bytes

Adding a static patch based on MR 22.