This is a follow up issue to #1155246: Use field group label in h2 above horizontal tabs group. I also needed to have label on top of vertical tabs.

I appreciate this one is trickier because vertical tabs is inside core but I have two requests, one that allows themer functions to do this in the same way as the patch in the horizontal issue, and one suggested addition that overrides the core's theme function to add support for the group label.

I think the first should really be accepted while the latter one I leave you to decide.

CommentFileSizeAuthor
#4 field_group-group-label-in-vertical-tabs-1577900-4.patch1.53 KBtostinni
#3 field_group-group-label-in-vertical-tabs-1577900-3.patch1.53 KBtostinni
#1 1577900-1-group-label-in-vertical-tabs.patch547 byteshanoii
#1 1577900-1-override-theme-core-vertical-tabs.patch1.28 KBhanoii

Comments

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
Status: Active » Needs review
StatusFileSize
new 1577900-1-override-theme-core-vertical-tabs.patch1.28 KB
new 1577900-1-group-label-in-vertical-tabs.patch547 bytes

Attached are both patches.

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
Issue summary: View changes

correcting referenced issue

hkdorama’s picture

hkdorama commented
Issue summary: View changes

This is something I also need. +1

tostinni’s picture

tostinni commented
Status: Needs review » Needs work
StatusFileSize
new field_group-group-label-in-vertical-tabs-1577900-3.patch1.53 KB

Here is an update of this patch, but I think it still some work to have the option of display or not this title.
Right now it's working and don't alter the core behaviour where there's no #title defined for the element.

tostinni’s picture

tostinni commented
StatusFileSize
new field_group-group-label-in-vertical-tabs-1577900-4.patch1.53 KB

Here is an updated version of the patch for 7.x-1.6

nils.destoop’s picture

nils.destoop commented
Status: Needs work » Closed (won't fix)