Random cleanups. Posting a patch once I have a nid.

Still TODO:

  • ExceptionController.php has copy&pasted doxygen for wrong @params.
  • Added methods, functions, parameters without adding doxygen.

Comments

Niklas Fiekas’s picture

Status: Active » Needs review
StatusFileSize
new9.26 KB

Pushed random clean-ups to 1578300-kernel-coding-style.

Niklas Fiekas’s picture

Pushed some more.

Niklas Fiekas’s picture

Issue summary: View changes

Add TODOs

Niklas Fiekas’s picture

Pushed some more changes reacting to reviews:
Revert an accidental change to make error_test module hidden again:

--- a/core/modules/system/tests/modules/error_test/error_test.info
+++ b/core/modules/system/tests/modules/error_test/error_test.info
@@ -3,4 +3,4 @@ description = "Support module for error and exception testing."
 package = Testing
 version = VERSION
 core = 8.x
-hidden = FALSE
+hidden = TRUE

Revert an unnescessary change to the RewriteRule:

--- a/.htaccess
+++ b/.htaccess
@@ -108,7 +108,7 @@ DirectoryIndex index.php index.html index.htm
   RewriteCond %{REQUEST_FILENAME} !-f
   RewriteCond %{REQUEST_FILENAME} !-d
   RewriteCond %{REQUEST_URI} !=/favicon.ico
-  RewriteRule ^(.*)$ index.php [L]
+  RewriteRule ^ index.php [L]
 
   # Rules to correctly serve gzip compressed CSS and JS files.
   # Requires both mod_rewrite and mod_headers to be enabled.
Crell’s picture

Status: Needs review » Fixed

Rebased, merged, pushed. Yay!

Niklas Fiekas’s picture

Status: Fixed » Needs review
StatusFileSize
new1.2 KB

:)

Pushed some more clean-ups, based on the review. Ok to re-use this generic clean-up issue?

Crell’s picture

That code has already been committed. Cross-coding. :-)

Niklas Fiekas’s picture

Status: Needs review » Fixed

:D

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

All TODOs done.