Drupal 6 modules although I believe it will function for 7.

http://drupal.org/sandbox/blueprint/1578204

git clone --recursive --branch 6.x-1.x blueprint@git.drupal.org:sandbox/blueprint/1578204.git

Permits adding any arbitrary lines to an aegir generated apache vhost config(not nginx yet: todo).

This is code for admins using aegir to manage multiple platforms/profiles in a clustering context.

The module only does minimal sanity checking. It is fairly simple to kill the vhost config for a single site if one enters garbage. But, gigo is the saying which follows upon the typing in fifo.

Comments

patrickd’s picture

patrickd commented

welcome,

Your module is in two folders, please make the module files laying in the git repositories root.

Your project page looks a little unstructured, you may use HTML tags and have a look at the, tips for a great project page.

Afterwards, while waiting for an in-depht review of your module you can start out fixing some coding style issues detected by automated tools: http://ventral.org/node/149309/repeat

We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.

regards

sylvain lecoy’s picture

sylvain lecoy commented
Status: Needs review » Needs work

Manual review:

As said by patrickd, make your modules files laying in the root folder.

A part from that, in your .drush.inc, class provisionService_vhost_generic_include extends provisionService { does not follow conventions. Conventions asks to begin class name with a capital letter, not camel case.

I put it as need work, for the folder structure, and the issues found with the automated tool (par review).

blueprint’s picture

blueprint commented

Will do the layout as soon as I can.

The name of the provision service class is not under my control. It's part of the aegir project.

Thanks for checking.

blueprint’s picture

blueprint commented
Status: Needs work » Closed (works as designed)
blueprint’s picture

blueprint commented
Issue summary: View changes

corrected mention of version.