[D7] uc_currency

welcome,

As installation and usage instructions are quite important for us to review, please take a moment to make your project page follow the tips for a great project page. Also make sure your README.txt follows the guidelines for in-project documentation.

while waiting for an in-depth review of your module you can start out fixing some coding style issues detected by automated tools:
http://ventral.org/pareview/httpgitdrupalorgsandboxiqbalnurhakim1576858git

change the repository url in project description to
git clone http://git.drupal.org/sandbox/iqbalnurhakim/1576858.git uc_currency

Manual Review:--

• variables should be prefixed with your module name. So, something like "uc_currency_currencies_convert" instead of a very generic "currencies_convert".
  

       variable_get('currencies_rate');
       variable_get('currencies_convert');
       variable_get('currency_base');
       variable_get('currencies_form_type');
  

• when you set up your module first you have : .info, README and .module for example (in the master branch) then you should start working ==> making a branch ( ie: 7.x-1.x) and putting your code in there
• When I setup your module, it was installed perfectly. But At currency setting page, when open the page, get an error "Please set your default currency code". There must be a default currency value.
• In uc_currency.admin.inc,
  <?php '#value' => variable_get('currency_base')?>
  please provide the default value when you are using variable_get() or variable_set()

We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.

regards

error!
Notice: Undefined index: USD в функции uc_currency_settings_form_submit() (line 110 в файле /sites/all/modules/uc_currency/uc_currency.admin.inc).

Hi,

You should reference your configuration page in the .info file:
configure = admin/store/settings/currency

A small thing: uc_currency.admin.inc line 9 – change "Tmplements hook_form()." to "Implements hook_form()."

You should delete your module variables, when the module is uninstalled (see hook_uninstall).

Regards, Christian

Does anyone have patches to work off of so far?

line 116 caused error.

variable_set('cuc_currency_convert', serialize($convert_currencies));

cuc_ prefix needs to be set to uc_

I have fixed line 116 error but still :
Notice: Undefined index: EUR in uc_currency_settings_form_submit() (line 110 of /home/....../www/sites/all/modules/uc_currency/uc_currency.admin.inc).

I've uploaded my changes to this module. They are somewhat significant, and I've renamed the archive to uc_currency_alt (but not the underlying files so to be careful)

Our approach is fundamentally different as we change the actual price on node_view and this change is carried through to the checkout.

• We use uc_price theme function only for changing the symbol and currency name, and use node view to change the underlying price.
• We've added the option for default currency and currency multipliers for making post conversion adjustments.
• Our version is compatible with the domains module allowing default currency and currency multipliers per domain. See the "Settings" tab for the domain
• We ensure that the currency can't be switched with a non empty shopping cart
• We ensure that the cart's currency is remembered between Sessions

Note: if you use this, your payment gateway needs to support the currencies you select, and you will need to update the code in your Payment gateways to change the working currency dynamically to be that of currency switcher SESSION variable. ( Some basic php skills are required for this - or feel free to contract us at http://southweb.co.nz )

I've made an update to the above archive to fix a flaw with Firefox and Drupal forms - i.e. ignoring the "selected" option. Get in touch if you want it.

Hi Iqbalnurhakim,

My first project in drupal. I am using multiple currency (uc_currency).

I am facing a problem with this module when i change the currency type currency value proper working but currency sing always keeping default sign (currency sign).

http://colourentice.com/color/catalog/charcoal
Please help me..

Thanks in advance ...

Thanks,
Abhijeet

Anyone use it with drupal7+ubercart?

I can not add currency, because at: admin/store/settings/currency page, add & save never be saved.
Need fix

btw: I use it on drupal7+ubercart3

very helpful to me, and this modified module successful change the currency and working on the check out.

i use local host to test this module, i just ignore the errors, still working.

this module really helps me a lot.

Thank you!

following changes worked for me

file uc_currency.admin.inc line no 110
original was
$currencies_rate[$item] =$input[$item];
I have change to
$currencies_rate[$item] = $item;

and line no 113
original was
variable_set('cuc_currency_convert', serialize($convert_currencies));
change to
variable_set('uc_currency_convert', serialize($convert_currencies));

Thank you Raysunil !

the module finally working. but it seems only can have one currency to switch.

all in all, im appriciate you help.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

thanks , myself too busy i will look on it.

Please add [D7] in the title. Please fix sniffer issues http://pareview.sh/pareview/httpgitdrupalorgsandboxiqbalnurhakim1576858git

Thanks,
Bappa

Raysunil: You are not the original applicant. This application was closed because the original applicant hadn't addresses any of the issues in a very long time (15 months!). Why are you re-opening this issue?

bappa.sarkar: You can change the title yourself. See, I've just done it ...

Hi Folks. This looks exactly what I was looking for. Is it going to make it as a module (i.e. drupal.org/project/uc_currency)? Anyone know if it's being worked on still? Any status advice welcome. :) Thanks

Closing again, as in #18. Original applicant still has not responded, and @Raysunil, who re-opened this issue, has presented no basis for doing so.

@den33775: Apparently the author of this module is not interested in continuing his development effort. As this is open source, you can use the existing code, and even apply to make it a module under your own name if you're willing to address the issues above.

change git repo url