Current code has lots of @todo comments inside, review them all and decide which ones need to be resolved for 7.x-1.0 release.

Don't forget to check/clean code with coder also.

CommentFileSizeAuthor
#1 multivariate_review_code_1579452_1.patch38.49 KBnonsie

Comments

nonsie’s picture

nonsie
she/her
Primary language Estonian
commented
Status: Active » Needs review
StatusFileSize
new multivariate_review_code_1579452_1.patch38.49 KB

Ran the code through coder and fixed most of the issues + removed some of the debug code.

pivica’s picture

pivica commented
Status: Needs review » Fixed

OK I needed to run all code through coder again - patch didn't apply because of recent commits. Implemented some other coder suggestions, added comments here and there, removed some old commented code, etc.

But I leaved some @todo parts for which I am still not sure what to do - for example parts for better entity implementation.

Commit 0b82645.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.