Hello!
Looks like Notifications module is more or less into the coma - and even if it wasn't, there are whole bunch of other messaging modules. It is useful to have ability to use them in conjunction with Mailcomment module - or even send outgoings e-mail with your own module. I had to write such a module (to realise sofisticated business logic), and just commented out Notifications-related code in Mailcomment and copied Message-ID-generating functions to my module. But that is not good solution in a long term.

So I'm ready to write a patch to move Notifications-related code into Mailcomment submodule, and to provide API function to generate Message-ID string. So those of us, who are happy with Notifications, will just enable this submodule and will use Mailcomment as they did; while others will be able to integrate other messaging module. Are there any chances for this patch to be committed?

Comments

danepowell’s picture

danepowell commented

Sounds like an awesome idea, I would gladly accept such a patch!

paolomainardi’s picture

paolomainardi commented

Hi renat, any chance to have your patch ?

nbchip’s picture

nbchip commented

Great idea, i would like to integrate it with http://drupal.org/project/message_notify module.

paolomainardi’s picture

paolomainardi commented

@nbchip great, me too, do you already have some code to share ?

nbchip’s picture

nbchip commented

not my, but here is something to try.
http://drupal.org/node/1730706

paolomainardi’s picture

paolomainardi commented

@nbchip thanks a lot for sharing, i didn't notice it yet

danepowell’s picture

danepowell commented
Title: Put Notifications-related code in submodule, provide an API to generate Message-ID string » Move Notifications integration into submodule.
Category: feature » task
Status: Active » Fixed

I moved Notifications integration into a submodule: http://drupalcode.org/project/mailcomment.git/commit/a34274f

This removes the dependency on Notifications from the main module, and also adds an update hook so that existing users will have the submodule enabled on upgrades.

This doesn't touch the message-ID generation function or provide any sort of new API- if those changes happen, they will probably be in conjunction with #1730706: Basic integration with Message Notify

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.