It seems, that FB changed its API again. If you are using XFBML tag <fb:login-button> you should no more use <fb:intl> inside of it. I think simple deleting of <fb:intl> should ne enough.

Hotfix and screenshot of problem (from http://www.drupalforfacebook.org/) attached.

CommentFileSizeAuthor
#13 fb_login_button.diff2.63 KBDave Cohen
dfb.png9.43 KBJiri Bazant
fb_button_hotfix1.patch617 bytesJiri Bazant

Comments

gargsuchi’s picture

gargsuchi commented

Facing the same issue with 6.x version as well.
@ Jiri Bazant - A simple deleting of what would be enough? can you please post.

thx
Suchi

gargsuchi’s picture

gargsuchi commented

ok
I fixed the lgoin button somewhat by removing the

</fb:intl>

and

</fb:intl>

from function theme_fb_login_button in fb_theme.inc.

This works now if I am not logged into FB in that browser, but in case i am logged in facebook in the same browser (in a diff tab) I dont see anything. any help please?

Jiri Bazant’s picture

Jiri Bazant commented

Sorry, I did not notice that FBML tags are stripped as well. There should be:
"It seems, that FB changed its API again. If you are using XFBML tag <fb:login-button> you should no more use tag <fb:intl> inside of it. I think simple deleting of <fb:intl> should be enough."

Dave Cohen’s picture

Dave Cohen commented

I'm not seeing this on drupalforfacebook.org. Was it just temporary?

I copied the fb:intl from their documentation a while back. Their doc no longer suggests that you can put any text in there.

gargsuchi’s picture

gargsuchi commented
Status: Active » Closed (fixed)

Seems to me that this was some intermittent problem from FB end. Is fixed now.

mayur.pimple’s picture

mayur.pimple commented

yes .. now Working fine...

jemond’s picture

jemond commented

I just starting seeing this issue today on 6.x.

jemond’s picture

jemond commented

Odd, after a few hours the issue went away.

jemond’s picture

jemond commented

This issue came back and didn't go away after 12 hours.

el_reverend’s picture

el_reverend commented

I can confirm the issue (http://www.nicolebyopi.com/user) on D6. It does not seems to be interrupting services however.

jemond’s picture

jemond commented

@el_reverend - Same here, just looks off but works fine.

jemond’s picture

jemond commented

FWIW, I chatted with Dave Cohen and we deployed a temp hotfix that overrides theme_fb_login_button() and removed the tags being inserted into the button code. I think there is a better longer term fix, but this worked for us for now.

Dave Cohen’s picture

Dave Cohen commented
Version: 7.x-3.x-dev » 6.x-3.x-dev
Status: Closed (fixed) » Needs review
StatusFileSize
new fb_login_button.diff2.63 KB

Here's a patch I'm testing. If you've configured your fb_connect block, you'll have to manually reconfigure it. This patch changes the defaults for that, and the theme_fb_login_button function.

Facebook's documentation still includes the XFBML option for a login button. But the example no longer shows the fb:intl tag. Just deleting that should be a workaround for now.

jemond’s picture

jemond commented
Status: Needs review » Reviewed & tested by the community

Working for our site, and fixes issue.

Dave Cohen’s picture

Dave Cohen commented
Status: Reviewed & tested by the community » Fixed

pushed it.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Added <code> wrappers.