With Drupal 7.10 everything was fine.
When upgrading to 7.14 this has changed
and the first level menu item won't get the active-trail
when a node assigned to a menu item below the first level.

Comments

globexplorer’s picture

Priority: Normal » Critical

I can reproduce this failure! I changed this to critical, and someone should roll back the MENU commits from the 7.12 branch.

The menu system is one of drupal most important parts. It is not acceptable that the whole menu system is not working anymore the way it should work.

Example (The current path is node/2):
Parent Menu Item - (path node/1) - won't get the active trail anymore
x Child Menu Item - (path node/2) - get's the active trail
x Child Menu Item - (path node/3)

The BAD commits can be found here:
http://drupal.org/node/1425104

History:
http://drupal.org/node/942782

Dear Drupal community!

Please be careful with your commits. It's always a bad sign when you can't trust the software you are working with O:(

pingers’s picture

Status: Active » Postponed (maintainer needs more info)

Cannot reproduce on a clean D8 or a clean D7 install (HEAD).

Is this an upgrade issue?
Or can you point to the actual problem in the code?
Please provide complete steps to reproduce the issue.

"Dear Drupal community!

Please be careful with your commits. It's always a bad sign when you can't trust the software you are working with O:("
These comments are not helpful. Please read http://drupal.org/dcoc

globexplorer’s picture

In my opinion I never wanted to blame somebody or to put somebody down. "Please be carful" is nothing more than a very well-intentioned call for more testing on commits.

We all want to be happy with Drupal. For me it's still the best open source cms software.

A more detailed report about the installed modules and settings will follow shortly.

CowTownFarmBoy’s picture

If this is an update or upgrade issue how might it be fixed? Do I have a way to rebuild both the primary and secondary menus without adding or dropping new pages in the menu? And btw I did not get any notification that there was a upgrade error, warning or issue when my menu's went off, how would I know this is the problem? Is just the fact that the menus do not work enough of a problem to indicate that it was a conversion error of some kind?

globexplorer’s picture

Use the version 7.10 and you will be fine. There are some commits regarding the menu system since 7.10, some of these are responsible for the misbehavoir.

CowTownFarmBoy’s picture

Thank you for the advice. Do you know if there is a problem going back from 7.14 to 7.10?

jlyon’s picture

It looks like this is the most likely culprit from http://drupal.org/node/1425104

#942782: Custom menus never receive an active trail by pillarsdotnet, xjm, becw, timhilliard, JohnAlbin, jrchamp, Tor Arne Thune, Damien Tournoud, jn2, James Andres, dstol, melon, colan: Fixed Custom menus never receive an active trail.

damienmckenna’s picture

Priority: Critical » Normal

Demoting this.

Please provide exact steps to reproduce this issue, and verify if the issue still exists with the latest 7.15 release.

dddave’s picture

Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)