securitytools

Hello,

See attached file for coding standards. I'd normally say use ventral.org, but you're repo doesn't seem to work with your git repository (the drupal one).

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

Hope this helps.

Pat

Please make sure all comments are in english, so other developers can easily participate and reviewers can understand all parts of your code. Also make sure all human readable strings in the module are properly wrapped with t() and are english!

Remove version = "6.x-1.0" from .info it will be added later by the version packaging system later automatically.

As installation and usage instructions are quite important for us to review, please take a moment to make your project page follow the tips for a great project page. Also create a README.txt that follows the guidelines for in-project documentation.

We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.

Hi, my manual review so far:

• There are still files other than README.txt in the master branch, make sure to remove them. See report http://ventral.org/pareview/httpgitdrupalorgsandboxm-gonzalez1576388git
• You are missing information on your project page, please take a moment to make your project page follow tips for a great project page.
• Please take a moment to make your README.txt follow guidelines for in-project documentation.

@ jleiva
Seems like you missunderstood the sense of the "review bonus" tag, please read https://drupal.org/node/1410826

yes sir, my mistake, thanks for the heads up!

This is good and works perfect.

This issue is not fixed, see http://drupal.org/node/532400

Sorry, before posting comments I should read work-flow process. Thanks for giving link.

Manual review of your project:

- There's still a master branch in your repository; should should delete it by using the command: git push origin :master
- In securitytools_form_alter you could use some newlines to improve readability; you're also using new lines inconsistently. Check out the coding standards on control structures, your break's aren't indented correctly.
- In ajax.inc, you have the function check_ajax_request ; you shouldn't start your functions with an empty line; that space in your if-clause should also not be there.
- In callback.inc, same comment about control structures; including the spaces in your if-clauses.
- Consider namespacing define('XSS_INTENT', t('Invalid format text')); .
- In validate.inc you have the function validate_node_view and a comment at the end of the body indicating the end of the function; I don't think that's common practice in Drupal; same for validate_node_save , you might also want to clean up your comments there.
- Most functions in the .inc files in your includes directory aren't namespaced correctly, they should start with the internal name of your module.
- Function validate_node_save uses form_set_error but it doesn't seem to get executed in the context of a form.
- In autocomplete_off.js you're not indenting correctly.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.