Hello,

EXCELLENT module BTW, thank you very much for making this!

I have run into an issue here. Based on my thread here, http://drupal.org/node/1393856, I moved my uc_followup folder to the Ubercart Contrib folder and then flushed my cache.

Then, when I viewed my Orders (admin/store/orders), the little Follow-Up letter icon (uc_followup/images/email.png) was missing! I flushed the cache again and reloaded the page and then the icon reappeared but they are all dimmed out; None of them have Pending Follow-Ups

When I load admin/store/follow-up, it shows all of my Follow-Ups are "Auto" but yet none of them are being sent out. I edited them, unactivated them and then reactivated them, yet the icons on the order page are still the grayed out letter icons.

I've also made sure the 'Send follow-ups automatically' is enabled on the settings page (admin/store/follow-up/settings) which it is.

Any clues or help would be greatly appreciated!!

Thanks
Mike

Comments

m.stenta’s picture

m.stenta
he/him
Primary language English
commented

Question: did you also update the module to version 1.2 in between? The new version of the module made some major changes to the query used to determine whether or not a followup needs to be sent. It could be that it's MORE accurate now than before. Previously, the icon you're describing was not accurately describing whether or not an email should have been sent. If you're interested in the specific changes made, see #1477036: Reworking uc_followup_cron() and the $mega_query.

Also, it's not good practice to put modules inside other modules. It makes updating modules a pain in the butt. Ubercart had that "contrib" folder in there since the beginning, but they recently removed it because it gave users the wrong idea (see this commit: http://drupalcode.org/project/ubercart.git/commit/49612e7ecd33a05a111e15...).

The best-practice approach is to put all contrib modules in (drupal)/sites/all/modules/contrib

BigMike’s picture

BigMike commented

Thank you for your quick reply and help!

Yes, I upgraded to the new version when I did this (I think right after I flushed the cache, then I updated), so............... I think what I can do is copy/backup the Followup's I've created (just jot them down in Notepad), uninstall the module, and then reinstall it. What do you think?

As for the contrib folder.............. What? Really?! Aaaarrrrrgggggg I just finished moving a bunch of modules into their contrib folder because I liked the concept of a cleaner module folder. Well, for me, this doesn't affect the way I update UC so I will just leave them in there ;)

Again, thank you very much for your quick reply and your help!!

Regards,
BigMike

m.stenta’s picture

m.stenta
he/him
Primary language English
commented

Do you think that the icon is greyed out because the necessary followups have already been sent? That is how it SHOULD work. But the changes in 1.2 didn't get a ton of testing, so if it's not working we should figure it out.

BigMike’s picture

BigMike commented

Thank you for your reply. I have Follow Ups that send out emails after a certain number of hours after order statuses are changed/updated. This should occur as often as any status is changed, however all of the orders whose status have changed (to 'Completed' for instance) are listed as...

[code]Pending follow-ups
No follow-ups were schedulled for this stage.

Processed follow-ups
No follow-ups were sent on this stage yet.[/code]

Despite the fact that my Follow Ups are indeed enabled as "Auto".

?

m.stenta’s picture

m.stenta
he/him
Primary language English
commented
Status: Active » Postponed (maintainer needs more info)

This will be hard to debug without seeing the data in your database. Are you on IRC? If so, ping me (nickname: mstenta) and maybe I can take a look at them. Don't post them here because it may expose customer data.

BigMike’s picture

BigMike commented

I literally haven't used IRC since 1994, but I could install a program if needed.

Update on this: Two weeks ago I went to admin/store/follow-up/settings and entered my email address to be Bcc'd. Just yesterday out of the blue my server began emailing me copies of follow-ups!! I looked at the order which created the follow up and sure enough the email was sent to me spot on for the time duration the follow up was configured for.

Then I looked at my order index (admin/store/orders) and all of the letter icons are the grayed out version, uc_followup/images/email.png. Unless changes were made, in the previous version Follow Up letter icons were grayed out (or a lightened icon) if there were no pending follow-ups, while pending follow-ups showed a strong, bold letter icon.

Moreover, all of my orders after the last order which I received a Bcc from show as "No follow-ups were schedulled for this stage."

It remains to be seen if I will receive any more Bcc's, in which case I will report back ASAP.

As for my server, it is a powerful Core i7 that averages 0.10-0.15 server loads and never has issues with dropping or missing emails with any other script on my website.

Will keep this updated, thanks
Mike

BigMike’s picture

BigMike commented

Holy smokes!

Since my last post my mailbox has been flooded with Follow-up Bcc's emails! I have received nearly 3 dozen in just the last few hours since.

So the Follow-Up system is sudden alive and well on my site, but I'm curious what changes were made to the letter icon? Did the file names change? Maybe I have the pending icon in place of the non-pending icon, which may have happened if the file names changed?

Additionally, I have confirmed that orders classified as "No follow-ups were schedulled for this stage." are indeed receiving Follow-Up emails and then changed to "Sent(1)" with Processed Follow-Up information present. If I hover my cursor atop the letter icon for an order that has not received a Follow-Up, the popup only reads in bold type, "Follow-up Summary". It does not show any Pending information. Then, after a short while, it will read ": pending(0) | sent(1)". Curious?

Regards,
BigMike

m.stenta’s picture

m.stenta
he/him
Primary language English
commented
Status: Postponed (maintainer needs more info) » Closed (works as designed)

Glad to hear it's working again! I'm not sure why it took a little while for it to kick into action.

In regards to your question: the updates made in #1477036: Reworking uc_followup_cron() and the $mega_query DID change the logic that was being used for displaying the icon. I basically rewrote it from scratch, because much of the previous logic was flawed. Read through the comments in that issue for more details.

As far as I know the final result should be the same as before, except for the fact that it is more accurate. Perhaps it wasn't showing you the correct icons earlier, and now it seems confusing because it is showing the right ones finally. Or at least the ones that were intended to be shown originally.

I'll mark this issue as "closed". If you think there's an issue with the icons, see if you can hone in on it a bit and figure out what is wrong about them, and open a new ticket specific to that issue. Thanks!

BigMike’s picture

BigMike commented

Thank you very much for your excellent support kind Sir.

Regards,
BigMike