Active
Project:
Mollom
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
15 May 2012 at 17:24 UTC
Updated:
25 Jun 2012 at 19:13 UTC
Jump to comment: Most recent file
Problem/Motivation
When using syslog for watchdog, log entries are subject to truncating based on configuration or network protocol limits (which vary system to system). Mollom log entries contain important data for reporting issues to Mollom after the postBody field, which if too long results in loosing these data.
Suggested fix
Because it will be impossible to programmatically know what logging limits may be imposed, provide a combo selection of postBody truncate lengths in Mollom settings: no truncating (default), 300 chars, 600 chars, 1200 chars. Add ellipsis to truncated strings.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | mollom_logging_truncate.patch | 2.4 KB | emsearcy |
| #1 | mollom_logging_truncate.patch | 2.37 KB | emsearcy |
Comments
Comment #1
emsearcy commentedMy initial estimate of 300, 600, 1200 was too high (I hadn't seen the rest of the log entry yet to know how much room needed to be left). My particular environment limit is 2048 chars and due to the repetition/batching of log info I found around 200 worked best for that limit. Many syslog environments only allow 1024 chars, though, so it could need to be lower.
The attached patch includes support for no truncating, 30, 90, and 180.
Comment #2
emsearcy commentedRevision, need to var_export the truncated postBody, not truncate the var_export'ed postBody (which causes the trailing quote to be stripped).