Upgrade from 4.7.x to 5.x-1.1
JirkaRybka - July 10, 2007 - 00:30
| Project: | Smileys |
| Version: | 5.x-1.1 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | won't fix |
Description
I had Smileys also on my 4.7.3 site. While upgrading to 5.1, Smileys didn't fix its database table, so no Smileys did show up, even new ones didn't. Looking into the code, I see there's no code for this upgrade.
I can't supply a ready-to-roll patch, but I fixed my existing database-table from 4.7.x using PhpMyAdmin, with the following queries. This should be included into the update script in some form. The first query probably needs some more bombproof file-paths-detection to be done first, but I'm too busy to check this now.
UPDATE `drup_smileys` SET `image`=( REPLACE (`image`,'modules/smileys/examples/','sites/all/modules/smileys/packs/example/'));
ALTER TABLE `drup_smileys` ADD `package` varchar(64) DEFAULT 'Uncategorized' NOT NULL;
#1
Thanks!! Committed to DRUPAL-5! It would be great if you can give it a test. :)
#2
Sorry for the delay (I was pretty busy recently).
I tested the upgrade (smileys.install file revision 1.2.2.4 from CVS repository) on my sites's data. The upgrade did its job perfectly, but there's a minor bug: The queries didn't go into the upgrade-log, so when finished, update.php said "no queries executed".
I took a look into a few other modules' .install files, to see how this should be done, and I think it's pretty clear. New patch attached here. I tested the resulting version again, the update works well, and shows correctly in the update-log too.
I think this is ready to be applied, as no new changes go into the queries, the rest is identical to other modules' upgrade scripts, and I successfully tested it on real data.
#3
I'm not entirely sure what's going on with this patch, but the patch file didn't work. Here's a new patch file, which worked fine to upgrade me from Drupal 4.6 to Drupal 5.
#4
My previous patch was against the file to be tested, which was (as I understand it) temporarily hidden from the public in CVS by making it "not the recent version" (unpatched file was included in CVS again as if it was a "newer" one). The patch in the post above is against the unpatched (CVS "recent") file, but otherwise both the patches give identical result.
#5
This fix never made it into upgrade.php. I upgraded to Drupal 5.7 this week, and had to manually update the smileys table to get it to work.
#6
#7
#8
Why was this wontfixed?
#9
4.7.x phased out completely over a year ago. And Drupal 5 is available since over 2 years now. Even D5 has started fading. Pretty much everyone who wanted to upgrade, has done so. If some rare dude hasn't yet, the patch's available here. They are on their own. Not worth it adding to the module.
PS: Hey, it's just logically about the worth-ness of the task, really. I don't offend contributions. :) Your contributions will always be appreciated, and incorporated when appropriate.
PS2: I'll leave some of my Drupal 5 contributions unsupported by the time Drupal 7 code freezes.
PS3: <<<< I want that.
#10
And, there it goes. ;)
#11
Understand. It helps to know why something is being marked wontfix. :)
#12
Sure, thanks! :)