Closed (fixed)
Project:
Menu Minipanels
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
15 May 2012 at 18:34 UTC
Updated:
4 Aug 2021 at 09:40 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
codycraven commentedThe attached patch addresses all three points of concern.
Comment #2
codycraven commentedForgot to mention, this also allows menu_minipanels to continue functioning if a site overrides the theming of menus to not use a ul li a structure.
Comment #3
damienmckennaNice patch. Committed.
Comment #4
damienmckennaThis needs to be ported to D7 so we can keep both codebases close.
Comment #5
damienmckennaComment #6
damienmckennaCould use some review.
Comment #7
damienmckennaIt appears to still work in my testing. I think it's good to go.
Comment #8
damienmckenna@codycraven: Out of interest, was there a reason to remove the $ in front of the 'target' variable? It was my understanding that was a coding standard for variables that point to jQuery objects?
Comment #9
damienmckennaUpon reading the JS coding standards I don't anything about using $, so I'm going to remove it.
Comment #10
damienmckennaOf course then I look in contextual.js and see lines like the following:
Comment #11
damienmckennaThis patch improves upon the one from #6 but makes the $var naming structure consistent.
Comment #12
damienmckennaThis patch for the D6 branch updates the variable naming.
Comment #13
damienmckennaCommitted. Thanks @codycraven.
Comment #15
damienmckenna