Closed (fixed)
Project:
Notify
Version:
4.7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
18 Jan 2005 at 22:29 UTC
Updated:
4 Jan 2007 at 23:47 UTC
Hello,
I periodically post items with "authored on" dates in the future for various reasons.
The Notify module sends out new notifications each time it runs for these items.
It should send a notification only when the item is first published.
Comments
Comment #1
laura s commentedBumping this, and designating it for the 4.6.0 version as this still happens in the latest release. I first noticed this behavior when using the scheduler and post-dating a post. Before it was even posted, notify started inundating all subscribers with notifications, over and over, at each notify cron point, until the post-dated post went live. Ironically, while the notify email would contain the content, nobody could see it on the site (as it wasn't published yet).
But there is an additional manifestation I've discovered since yesterday (post-4.6.3 update), when my ecto client started not syncing well with the site's time settings. As such, my posts composed on ecto go up with a date 3 hours "in the future." This leads to what the original poster reported:
Notify sends an email at every designated time, until that time is reached on the site's default time-zone.
What would be best (IMHO):
* Notify sends only one email per user for a new post.
* Notify sends another email only if there's a revision to the post.
(* Notify works with scheduler etc. and sends emails only upon publication. Not sure if this is a scheduler or notify issue.)
Thanks.
Comment #2
spudart commentedI'm also using Scheduler with Notify (with Drupal 4.6.5). Notify has been working fine with regular posts, but when I assign a post with a future date with Scheduler, this type of post doesn't get sent at all. So it sounds like the exact opposite of laura's problem above where she was getting the notify emails sent out too early and often.
Comment #3
sangamreddi commentedFor me its working well as expected. I am using scheduler and notify on drupal 4.6.5. It send mails only when the posts are published. I don't have ny problem with it as metioned above. Please check your settings once.
Comment #4
RobRoy commentedAre you guys still experiencing this with future dated posts?
Any thoughts?
Comment #5
Capnj commented4.7 version of notify constantly sends items with future dates. I too use future dates a sort of a "super-sticky" thing.
gil
Comment #6
kthagen commentedI tend to think this should be marked "won't fix." Altering notify would lead to other problems.
This behavior should only occur under the following scenario.
1. A user manually sets a future date for the peice,
2. The piece is published or queued for moderation,
3. The scheduler module is NOT installed. (If it is, scheduler will take care of setting the published flag at the correct time).
You could easily filter out future-dated posts by changing the final part of the WHERE clause the node query to read
But then you wouldn't be notified about the node at the time it was really posted, which is probably undesired behavior.
The other option would be to track what posts we've sent notifications about, which seems to me like a waste of space in the database. If user's really want future publication, they should be using scheduler, in which case this isn't an issue. If they're using the publication date as a hack to control display order, well, they're misusing the field and should expect unpleasant side-effects.
Comment #7
RobRoy commentedI've actually made this fix to HEAD and DRUPAL-4-7 adding "AND n.created <= %d" to the SQL statement like kthagen states. I think this is the desired behavior since if you are future dating posts, you really want them to be publicly created at that future date.
Comment #8
(not verified) commented