Problem/Motivation

Not trying to be an @ss but I'm curious why you manually loaded the parent ctools plugin in this case:

./plugins/context_reaction_addcss.inc:11

// Load the base Add Assets Reaction class
if (!class_exists('context_reaction_addassets_base')) {
  module_load_include('inc', 'context_addassets', 'plugins/context_reaction_addassets_base');
}

Instead of using the standard inheritance system, defining 'parent' for the child. I notice that you set parent="context_reaction" for your plugins and then manually include the _base.

Proposed resolution

If it's because the addassets_base class an abstract, then I believe there an 'abstract' property that prevents use of the plugin as an end plugin? You simple add 'abstract'=>true in the plugin definition, which affects the ctools plugin loader.

This is a very very low priority item, I just saw it and wondered aloud.

Comments

chrisjlee’s picture

Version: 6.x-1.0-beta1 » 7.x-1.x-dev

Interesting. Forgive me I'm just gaining familiarity with this modue. Could you please provide an example/patch of what you would believe as the best implementation?

jtwalters’s picture

Issue summary: View changes
Status: Active » Postponed (maintainer needs more info)

If anyone can provide a patch for this, that would be great! Otherwise, seems to work as is.