Port simpletest to 6.x

Rok,

I've downloaded the CVS version of the simpletest module, applied 'simpletest.d6port.patch', downloaded simpeltest from sourceforge and added it to the simpletest module dir with the following result in the 'Simpletest unit testing' menu item:

Fatal error: Call to undefined method DrupalUnitTests::_requireWithError() in /var/www/d6/drupal/sites/all/modules/simpletest/drupal_unit_tests.php on line 42

My bad or bug?

-H-

That sure helps!

I'd reckon that most tests aren't ported to Drupal 6 yet? A lot of the tests fail, even on a 'clean' checkout of Drupal 6...

-H-

This is my first encounter with unit tests. I'm currently researching tools/methods to perform tests through a cron job.

Simpletest looks very promising, except for the fact that the Drupal module depends on a slightly older version...

If I encounter any (easy) fixable bugs, I'll surely report them here...

-H-

Ehm, how can I launch a test from the CLI? Or is this not possible?

I've cooked up the following script to run tests from the command line:

require_once(dirname(__FILE__) . '/../../../../includes/bootstrap.inc');
drupal_bootstrap(DRUPAL_BOOTSTRAP_FULL);

require_once(dirname(__FILE__) . '/simpletest/compatibility.php');
require_once(dirname(__FILE__) . '/simpletest/browser.php');
require_once(dirname(__FILE__) . '/simpletest/web_tester.php');
require_once(dirname(__FILE__) . '/simpletest/unit_tester.php');
require_once(dirname(__FILE__) . '/simpletest.module');
require_once(dirname(__FILE__) . '/drupal_test_case.php');
require_once(dirname(__FILE__) . '/drupal_unit_tests.php');
require_once(dirname(__FILE__) . '/drupal_reporter.php');

if ((preg_match("/^test=/", $argv[1])) and (preg_match("/^url=/", $argv[2]))) {
  $sTests = preg_replace("/^test=/","",$argv[1]); // remove 'test=' part
  $aTests = explode(",",$sTests); // cast into an array
  
  $sCLI_URL = preg_replace("/^url=/","",$argv[2]); // remove 'url=' part
  if (!preg_match("/\/$/", $sCLI_URL)) $sCLI_URL.="/"; // add missing trailing slash
  
  $output = simpletest_run_tests($aTests);
  simpletest_running_output($output);
}
else {
  die ("\nUsage:\n\tphp ".$argv[0]." test=\"Test 1[,Test 2]\" url=http://localhost/drupal_path/\n\n");
}

I've named it "simpletest_cli.php" and put it the Simpletest module directory (sites/all/modules/simpletest/simpletest_cli.php)

When running Drupal from the CLI, the url() function doesn't create a 'http://' like url. Use this ugly hack to get tests working again.

Edit 'drupal_test_case.php' around line 104:

function drupalPostRequest($path, $edit = array(), $submit, $edit_multi = array()) {
  global $sCLI_URL;
  if (isset($sCLI_URL))
    $url = $sCLI_URL.$path;
  else
    $url = url($path, array('absolute' => TRUE));

I've got little Drupal experience, so please tell me if I'm totally wrong on this one...

-H-

rok - we may not need that script anymore in D6 version. instead, we could ask folks to use the new /scripts/drupal.sh with the right url (we might need to build this callback). i didn't look at run_all_tests, so i might be wrong on this.

I might be wrong on this, but doesn't the drupal.sh output formatted (=html) text?

As for "run_all_tests.php", it has 'require_once' issues, I doubt that it handles url's correctly, and it isn't possible to specify a specific test, so I'm sticking with my own script for the moment.

If time permits, I'll try to fix some tests on D6 once I've fully mastered the art of testing...

Cheers!

-H-

PS: I wasn't aware that I could change the title of the issue, I thought it was the title of my own post... Sorry 'bout that...

I've attached a patch that fixes all tests (except for the 'Image Module' test) on a fresh checkout of Drupal 6. Basically, all the 'Submit' buttons are replaced by 'Save' buttons...

Current test result: 443 passes, 0 fails and 0 exceptions.

-H-

This patch combines the above two so that it can be applied in one go.

Patch updated for the removal from the DB API of db_num_rows().

Seems to work now.

I added an 'administer users' permission to single profile field testing. That helped -- we did not need to test profile for D6 beta. I love simpletest.