Themes Blue_zinfandel and thirteen don't load FCKeditor properly. I don't know why. The pop-up works. Firebug shows that the .js file is loading. Other themes work as expected.

Please advice in the README.txt and admin/settings/fckeditor page to "CHANGE THE THEME TO DEFAULT" if FCKeditor doesn't seem to work properly.

Thanks.

Does anybody know how to fix this?

(Just another example why it's important to put it in documentation:
http://drupal.org/node/149681, but is not the problem in my case)

Comments

ontwerpwerk’s picture

ontwerpwerk CreditAttribution: ontwerpwerk commented
Status: Active » Closed (won't fix)

FCKeditor works with the core themes, so those themes probably mess up somewhere.

please file a bug report for the themes that break it..

alldirt’s picture

alldirt CreditAttribution: alldirt commented

Bugreports:
http://drupal.org/node/158409
http://drupal.org/node/158410

This issue is filed under documentation. I think the docs need to address the possible problems with non core themes. I hope you will fix this.

ontwerpwerk’s picture

ontwerpwerk CreditAttribution: ontwerpwerk commented

How will a warning in the FCKeditor module documentation solve the problem. The theme should be fixed to fix the problem.

(even worse: if the theme is fixed the FCKeditor documentation needs to be updated again - whis is a useless effort twice)

alldirt’s picture

alldirt CreditAttribution: alldirt commented

If you don't see the problem (or what a warning will fix), I probably haven't been clear.

Suppose someone wants to install FCKeditor. He follows README.txt and doesn't forget a thing. Still FCKeditor doesn't work.

What could be the problem? He starts checking every step he has done, starts searching Drupal.org, starts googling, starts asking questions on the forum, submitting support question in the issues tracker, meanwhile checking filesystems again, permissions, different browsers, settings in the admin pages, access control pages etcetera.

In some cases you could prevent this by advising to use a default theme in the README.txt . You don't have to state the themes that are broken! I think that a README.txt should need to state what people need to know to get FCKeditor working and changing the theme may be one of them.

Does this make sense?

alldirt’s picture

alldirt CreditAttribution: alldirt commented
Status: Closed (won't fix) » Active

Issues set to active again

One more example: http://drupal.org/node/110528

ontwerpwerk’s picture

ontwerpwerk CreditAttribution: ontwerpwerk commented
Status: Active » Closed (won't fix)

Yes.. and where do I stop? when I have every possible situation, and every possible user error covered... I personally believe that to be impossible - so I stop when I have to cover for edge cases like contributed theme x has a problem with your module when most other themes just work

alldirt’s picture

alldirt CreditAttribution: alldirt commented

Ok, then don't bother. We'll have to document it in the forums.

Still, I don't agree theming is an edge case scenario. I would guess most people will have used themes before they consider FCKeditor.

ontwerpwerk’s picture

ontwerpwerk CreditAttribution: ontwerpwerk commented

I'm not saying theming is an edge case - I'm saying those two themes (or 5 or 20) are edge cases because those themes break the default behaviour and because there are working examples available. It is the responsibility of the maintainers of those themes to fix it, not my responsibility to warn users about it.

quixote’s picture

quixote CreditAttribution: quixote commented
Status: Closed (won't fix) » Fixed

I think I've found a fix for themes that don't load FCKeditor. Those of you in need please test and see if it works for you as it did for me.

Make sure your template includes print $closure near the bottom of the page.

I had created a totally new template that uses PHPTemplateEngine but was totally homebrew. Everything was great except no FCKeditor. Finally I compared my template w/ some others that work. The difference was the $closure code. As recommended elsewhere on the boards, I also include the code print $scripts near the top.

Hope this helps, folks!

alldirt’s picture

alldirt CreditAttribution: alldirt commented
Status: Fixed » Closed (won't fix)

Yes thanks!
It works for the themes I checked and updated those bugreports.

However, it doesn't fix the problem with the documentation.

ontwerpwerk’s picture

ontwerpwerk CreditAttribution: ontwerpwerk commented
Status: Closed (won't fix) » Fixed

Actually it is documented in the theme developers guide... $closure is a required component.

http://drupal.org/node/11812

alldirt’s picture

alldirt CreditAttribution: alldirt commented

won't fix to won't fix

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)
TheBasher’s picture

TheBasher CreditAttribution: TheBasher commented

Hey Sorry I'm a complete noob to drupal... but I was using a theme that didn't allow fckeditor to work either and I just changed the administration theme and I was able to get it to work that way? is that a bad way of doing it?

wwalc’s picture

wwalc CreditAttribution: wwalc commented

You may try to fix your theme: http://drupal.fckeditor.net/troubleshooting
Try the trick with closure & scripts.

persyl’s picture

persyl CreditAttribution: persyl commented

Yes, adding the $closure variable at the bottom of page.tpl.php solved the problem in my theme!!!
Thanks!

bsheaff’s picture

bsheaff CreditAttribution: bsheaff commented

To get my theme to work I added a script tag with the insides:

type="text/javascript" src="/drupal/modules/fckeditor/fckeditor/fckeditor.js?I"

To my page.tpl.php file, before all the other javascript.

basically I was not getting the fckeditor.js into my template and I could see that when I switched the theme to
Garland that it was there.

This fixed it for me.