fix to work with jQuery 1.2.6
m3avrck - July 11, 2007 - 05:07
| Project: | Smileys |
| Version: | 5.x-1.2-beta |
| Component: | Code |
| Category: | support request |
| Priority: | normal |
| Assigned: | Virr |
| Status: | needs review |
Description
Attached patch fixes the JS error when using jQuery 1.1.x +
| Attachment | Size |
|---|---|
| ts_13.patch | 738 bytes |
#1
Actually, it should be
<?php- $('#showSmileysWindow').oneclick(function() {
+ $('#showSmileysWindow').one('click', function() {
?>
if you want to run the module with jQuery 1.1 and onwards.
However, this won't make into the module, because it'll break with default drupal 5 installation.
#2
I tried both the proposed patches but it doesn't work. I'm using jQuery 1.2.6
#3
Doesn't work for me on 1.2.6, either. At least not out of the smilies fieldset. If I click show all and use that icon box it works. Setting this back to active... I understand your won't fixing as far as the module goes but any chance of providing an updated patch? Unfortunately, I don't know js so no clue.
Thanks,
Michelle
#4
You tried the fix in comment #1 right?
If that doesn't fix the problem, you may want to try out the js file from DRUPAL-6--1 branch.
#5
Yes, I did #1 and that didn't work. The file from the D6 branch did, though. Since you've already said you won't change it in the module (which makes sense) then confirming that works seems fixed enough to me.
Thanks,
Michelle
#6
Hmm... I just noticed that using the 6.x code fixed the fieldset but broke the "show all" link. Any suggestions to get them both working at the same time with 1.2.6?
Thanks,
Michelle
#7
My version of the script. Adding Smiley like works:)
#8
#9
Thanks for the patch Virr. It works for me.
Only the 'more' link to the pop-up window is disabled by the patch - but for me it's not so important
Good work!
:o)
#10
More link not important for me too :) yr welcome :)
#11
new version with working "more" link
#12
Can you tell exactly what was changed? A diff would be great!
#13
D6 version of smileys.js didnt work for me. I am using D5 with JQuery 1.2.6, however the last patch by Virr worked a treat!
I have attached a diff file for your reference.
edit: erm hold that thought! it doesnt seem to insert any Smilies in the Node, only in the comments! I have tried the "more" link in nodes and no joy..
re-edit: fixed. sorry it was FCKEditor messing up smilies on Forum Nodes, read more here: http://janaksingh.com/blog/drupal-5-disable-fckeditor-content-type-79. I can confirm the last patch to be fully working in D5 with JQuery 1.2.6