Download & Extend
Smileys » Issues

fix to work with jQuery 1.2.6

Posted by m3avrck on July 11, 2007 at 5:07am
Project:Smileys
Version:5.x-1.2-beta
Component:Code
Category:support request
Priority:normal
Assigned:Virr
Status:needs review

Issue Summary

Attached patch fixes the JS error when using jQuery 1.1.x +

AttachmentSize
ts_13.patch738 bytes
Login or register to post comments

Comments

#1

Posted by Gurpartap Singh on June 10, 2008 at 5:50pm
Status:reviewed & tested by the community» closed (won't fix)

Actually, it should be

<?php
-  $('#showSmileysWindow').oneclick(function() {
+  $('#showSmileysWindow').one('click', function() {
?>

if you want to run the module with jQuery 1.1 and onwards.

However, this won't make into the module, because it'll break with default drupal 5 installation.

#2

Posted by jmai on June 11, 2008 at 7:23am

I tried both the proposed patches but it doesn't work. I'm using jQuery 1.2.6

#3

Posted by Michelle on August 25, 2008 at 4:33pm
Category:bug report» support request
Status:closed (won't fix)» active

Doesn't work for me on 1.2.6, either. At least not out of the smilies fieldset. If I click show all and use that icon box it works. Setting this back to active... I understand your won't fixing as far as the module goes but any chance of providing an updated patch? Unfortunately, I don't know js so no clue.

Thanks,

Michelle

#4

Posted by Gurpartap Singh on August 25, 2008 at 5:12pm

You tried the fix in comment #1 right?

If that doesn't fix the problem, you may want to try out the js file from DRUPAL-6--1 branch.

#5

Posted by Michelle on August 25, 2008 at 7:03pm
Status:active» fixed

Yes, I did #1 and that didn't work. The file from the D6 branch did, though. Since you've already said you won't change it in the module (which makes sense) then confirming that works seems fixed enough to me.

Thanks,

Michelle

#6

Posted by Michelle on August 25, 2008 at 10:45pm
Title:fix to work with jQuery 1.1» fix to work with jQuery 1.2.6
Status:fixed» active

Hmm... I just noticed that using the 6.x code fixed the fieldset but broke the "show all" link. Any suggestions to get them both working at the same time with 1.2.6?

Thanks,

Michelle

#7

Posted by Virr on January 7, 2009 at 11:03am
Version:5.x-1.x-dev» 5.x-1.2-beta
Assigned to:Anonymous» Virr
Status:active» fixed

My version of the script. Adding Smiley like works:)

AttachmentSize
smileys.js_.txt 3.25 KB

#8

Posted by Gurpartap Singh on January 7, 2009 at 2:05pm
Status:fixed» needs review

#9

Posted by plan9 on February 20, 2009 at 3:29pm

Thanks for the patch Virr. It works for me.
Only the 'more' link to the pop-up window is disabled by the patch - but for me it's not so important

Good work!

:o)

#10

Posted by Virr on March 12, 2009 at 11:42am

More link not important for me too :) yr welcome :)

#11

Posted by Virr on March 14, 2009 at 1:37am

new version with working "more" link

AttachmentSize
smileys.zip 1.52 KB

#12

Posted by Gurpartap Singh on June 27, 2009 at 5:18pm

Can you tell exactly what was changed? A diff would be great!

#13

Posted by dakku on November 11, 2009 at 1:03pm

D6 version of smileys.js didnt work for me. I am using D5 with JQuery 1.2.6, however the last patch by Virr worked a treat!
I have attached a diff file for your reference.

edit: erm hold that thought! it doesnt seem to insert any Smilies in the Node, only in the comments! I have tried the "more" link in nodes and no joy..

re-edit: fixed. sorry it was FCKEditor messing up smilies on Forum Nodes, read more here: http://janaksingh.com/blog/drupal-5-disable-fckeditor-content-type-79. I can confirm the last patch to be fully working in D5 with JQuery 1.2.6

AttachmentSize
diff.txt 9.86 KB