Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
theme
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
16 May 2012 at 16:15 UTC
Updated:
22 Oct 2012 at 19:41 UTC
Jump to comment: Most recent file
Comments
Comment #1
pgogy commentedHello,
Ventral (a coding standards checker) reports some issues for you (there are quick to fix, so don't worry about the length)
http://ventral.org/pareview/httpgitdrupalorgsandboxj0ey1585582git
It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
README.txt is missing, see the guidelines for in-project documentation.
Remove "version" from the info file, it will be added by drupal.org packaging automatically.
The links above show you what to do to fix these.
Hope this helps
Pat
Comment #2
j0e commentedThanks Pat. Moved to version specific branch, fixed .info and added readme.txt.
Joseph
Comment #3
igoen commentedHi, I do automated project review in Ventral.org and your theme have some errors. Average of your errors is your coding style is not standard. I think your theme is clean and elegant. Good work.
( See in ventral.org or in attached file. But better if you go to ventral.org by yourself. Good luck. )
Comment #4
klausiClosing due to lack of activity. Feel free to reopen if you are still working on this application.
Comment #4.0
klausiadded title and restructured application