Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
simpletest.module
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
17 May 2012 at 11:35 UTC
Updated:
29 Jul 2014 at 20:42 UTC
Jump to comment: Most recent file
Comments
Comment #1
berdirThis is a windows issue because on Linux, creating a filename with a \ in it works fine.
The path is generated once in in simpletest_verbose() and once in WebTestBase::verbose().
simpletest_verbose() is only used within WebTestBase. I suggest we merge these two functions and replace \ in $class with _ or something like that.
Comment #2
aspilicious commentedWorking now
Comment #3
aspilicious commentedFollowup #1588132: Simpletest verbose output url generation should be centralized.
Comment #4
underq commentedWork for me !
Comment #5
berdirThis is the easiest fix for the given bug. Not sure if it makes sense to add a test here, we don't have any test coverage of verbose() yet at all. I'd vote for checking whether we can add test coverage in #1588132: Simpletest verbose output url generation should be centralized..
Comment #6
marcingy commentedThis also works for me bumping to major as it basically prevents tests being run in a meaningful way on windows
Comment #7
sunLooks good to me. Would have preferred single quotes (like everywhere else in Drupal), but I won't hold off a commit on that. If you can quickly tweak that and upload a new patch before this gets committed, even better.
Comment #8
aspilicious commentedLets see if this works
Comment #9
berdirComment #10
catchWorks for me, fine with not adding tests for this and great if we can add them in the other issue.