Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.I have tested this with Safari, Firefox and Chrome and results are exactly the same.
Eldir style for form items labels looks like below:
div.form-item label.option,
div.form-item label.option * {
font-size:1em;
vertical-align:middle;
}
It should be:
div.form-item label.option,
div.form-item label.option * {
font-size:1em;
vertical-align:inherit;
}
See the difference in the attached screenshots.
| Comment | File | Size | Author |
|---|---|---|---|
| vertical-align-inherit.jpg | 56.19 KB | omega8cc | |
| vertical-align-middle.jpg | 57.61 KB | omega8cc |
Comments
Comment #1
steven jones commentedThis will need testing with one of the IEs too.
Comment #2
omega8cc commentedThe patch: http://drupalcode.org/sandbox/omega8cc/1074912.git/commit/9e97fcb
Comment #3
omega8cc commentedIndeed, as "inherit" is supported probably only in IE 8 and 9, however I'm not sure if not supported property value is worse than incorrect "middle". I don't have any Windows machine to test this :/
[EDIT] See also: http://www.w3schools.com/cssref/pr_pos_vertical-align.asp
Comment #4
omega8cc commentedFixing the title.
Comment #5
omega8cc commentedJust tested this with Opera and it works the same, so only IE 7 needs testing?
Comment #6
anarcat commentedIs this RTBC? do we care that much about IE7?
And why do we need to specify vertical-align if it's going to "inherit"? Wouldn't just removing the directive work?
Comment #7
steven jones commentedI reckon that just removing that CSS should do the trick, as anarcat sugested in #6. So I've removed it in 6.x-2.x. Thanks for the patches and the testing!