I have tested this with Safari, Firefox and Chrome and results are exactly the same.

Eldir style for form items labels looks like below:

div.form-item label.option,
div.form-item label.option * {
  font-size:1em;
  vertical-align:middle;
  }

It should be:

div.form-item label.option,
div.form-item label.option * {
  font-size:1em;
  vertical-align:inherit;
  }

See the difference in the attached screenshots.

CommentFileSizeAuthor
vertical-align-inherit.jpg56.19 KBomega8cc
vertical-align-middle.jpg57.61 KBomega8cc

Comments

steven jones’s picture

steven jones commented

This will need testing with one of the IEs too.

omega8cc’s picture

omega8cc commented
Status: Active » Needs review

The patch: http://drupalcode.org/sandbox/omega8cc/1074912.git/commit/9e97fcb

omega8cc’s picture

omega8cc commented
Title: All radios labels in forms use incorrect vertical-align property value (middle) » All radios labels in forms use incorrect vertical-align property

Indeed, as "inherit" is supported probably only in IE 8 and 9, however I'm not sure if not supported property value is worse than incorrect "middle". I don't have any Windows machine to test this :/

[EDIT] See also: http://www.w3schools.com/cssref/pr_pos_vertical-align.asp

omega8cc’s picture

omega8cc commented
Title: All radios labels in forms use incorrect vertical-align property » All radios labels in forms use incorrect vertical-align property value (middle)

Fixing the title.

omega8cc’s picture

omega8cc commented
Title: All radios labels in forms use incorrect vertical-align property » All radios labels in forms use incorrect vertical-align property value (middle)

Just tested this with Opera and it works the same, so only IE 7 needs testing?

anarcat’s picture

anarcat commented

Is this RTBC? do we care that much about IE7?

And why do we need to specify vertical-align if it's going to "inherit"? Wouldn't just removing the directive work?

steven jones’s picture

steven jones commented
Status: Needs review » Fixed

I reckon that just removing that CSS should do the trick, as anarcat sugested in #6. So I've removed it in 6.x-2.x. Thanks for the patches and the testing!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 8fc6334 on 6.x-2.x, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by Steven Jones: 
    Issue #1587232 by omega8cc: Fixed All radios labels in forms use...

  • Commit 8fc6334 on 6.x-2.x, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by Steven Jones: 
    Issue #1587232 by omega8cc: Fixed All radios labels in forms use...