Classes that override views_content_cache_key::options_form() need to do so consistently to avoid strict warnings in PHP 5.3+

Patch to follow.

CommentFileSizeAuthor
#9 1587324-9-views_content_cache-prevent_strict_warnings-D6.patch3.42 KBjwilson3
#4 1587324-3-views_content_cache-prevent_strict_warnings.patch3.21 KBelliotttf
#1 1587324-1-views_content_cache-prevent_strict_warnings.patch52.16 KBelliotttf

Comments

elliotttf’s picture

elliotttf commented
StatusFileSize
new 1587324-1-views_content_cache-prevent_strict_warnings.patch52.16 KB
elliotttf’s picture

elliotttf commented
Status: Active » Needs review

Updating issue status.

Status: Needs review » Needs work

The last submitted patch, 1587324-1-views_content_cache-prevent_strict_warnings.patch, failed testing.

elliotttf’s picture

elliotttf commented
Status: Needs work » Needs review
StatusFileSize
new 1587324-3-views_content_cache-prevent_strict_warnings.patch3.21 KB

Sorry... diffed against master instead of 7.x-3.x. New patch attached.

dmitriy.trt’s picture

dmitriy.trt commented
Status: Needs review » Reviewed & tested by the community

Patch #4 works. Thanks, elliotttf!

We've experienced this bug on PHP 5.4, maybe it's important.

steven jones’s picture

steven jones commented
Status: Reviewed & tested by the community » Fixed

@elliotttf Thanks very much for the patch. Committed to 7.x-3.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Issue summary: View changes
Status: Closed (fixed) » Patch (to be ported)

This needs a Backport to Drupal 6.

The errors being reported in D6, using Views 2:

Strict warning: Declaration of views_content_cache_key_comment::options_form() should be compatible with views_content_cache_key::options_form($value, &$handler) in ctools_plugin_get_class() (line 770 of ctools/includes/plugins.inc).
Strict warning: Declaration of views_content_cache_key_node_only::options_form() should be compatible with views_content_cache_key::options_form($value, &$handler) in ctools_plugin_get_class() (line 770 of ctools/includes/plugins.inc).

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Version: 7.x-3.x-dev » 6.x-2.x-dev
Status: Patch (to be ported) » Needs review
StatusFileSize
new 1587324-9-views_content_cache-prevent_strict_warnings-D6.patch3.42 KB

Backported patch from #4 for views_content_cache-6.x-2.x-dev