The nagios_status_page() callback makes two passes over elements in the $nagios_data array, once to set the global severity and once to report each check's value. The attached patch rewrites that to make a single pass and save a bit of processing load.

CommentFileSizeAuthor
#3 drupal_8_single_loop_pass-1587696-3.patch1.56 KBgreg.harvey
single_loop.patch1.67 KBbarrett

Comments

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
Issue summary: View changes
Status: Needs review » Needs work

I'm sure this is fine, but we should really do a Drupal 8 version of the patch at this point.

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented

I actually committed this, apparently - it must have snuck through in another commit. Apologies for the lost credit! I'll make it up to you when I commit the same to Drupal 8, if I can!

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented
StatusFileSize
new drupal_8_single_loop_pass-1587696-3.patch1.56 KB

Drupal 8 patch attached.

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented
Status: Needs work » Needs review

  • greg.harvey committed e8c9863 on 8.x-1.x authored by Barrett 
    Issue #1587696 by greg.harvey, Barrett: nagios_status_page() makes...
greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented
Status: Needs review » Fixed

Committed! Credit went to Barrett for original patch, apologies for missing that first time. Still not sure how it got committed for the 7.x-1.x branch!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.