This one kinda came out of nowhere...hadn't changed much on the site in a while and went to edit a user entity, which has an office hours field on it, didn't mess with the office hours, actually edited other info and got this...any ideas? I pulled down the latest dev just to be sure, and I see the function is defined in office_hours.elements.inc...what could it be?

CommentFileSizeAuthor
#6 0001-Fix-for-commit-67655c0.patch1.88 KBLazarus-Long

Comments

Ozeuss’s picture

Ozeuss commented

I don't see this on latest dev, are you sure your version is clean? any other info?

johnv’s picture

johnv
Primary language Dutch
commented

This recent commit removed some superfluous(?) file includes.
Perhaps it was too much?

@scot.self,
did this happen after or before updating to latest -dev?

scotwith1t’s picture

scotwith1t
Location Birmingham, AL
commented

Was on 7.x-1.0+3-dev. Updated to the current dev dated today and msg is gone. Thx.

scotwith1t’s picture

scotwith1t
Location Birmingham, AL
commented
Status: Active » Closed (fixed)
Ozeuss’s picture

Ozeuss commented

Actually the issue wasn't closed- the error function came up because the module couldn't find elements.inc - I moved the module load include call to the top of the file (code commited to dev)

Lazarus-Long’s picture

Lazarus-Long commented
StatusFileSize
new 0001-Fix-for-commit-67655c0.patch1.88 KB

After the commit, fields that are not validating hours won't have any options on the widget. Here's the patch.

johnv’s picture

johnv
Primary language Dutch
commented
Status: Closed (fixed) » Needs review

@Lazarus-Long, you should open a new issue for your patch, since it has no (functional) relationship with the issue.
A patch in a closed issue will never be reviewed.

Ozeuss’s picture

Ozeuss commented
Status: Needs review » Closed (fixed)