Closed (fixed)
Project:
Drupal.org Library Packaging Allowlist
Component:
Whitelist request
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
18 May 2012 at 09:27 UTC
Updated:
14 Sep 2019 at 09:14 UTC
Jump to comment: Most recent
Comments
Comment #1
geerlingguy commentedDoes CiviCRM include Drupal core already? I haven't used it in a while, but I thought they already prepackaged everything together in that archive. If that's the case, there's no need to include that package in a distribution on drupal.org.
However, if there's a 'CiviCRM module pack' or something that can be included in a distribution separately, that'd be acceptable.
Comment #2
kreynen commentedThe CiviCRM download does NOT include Drupal core, but it DOES include libraries that are also included in Drupal like JQuery. While that's redundant for Drupal, the same core CiviCRM's codebase is designed to work with different versions of Drupal as well Joomla and Wordpress... so it makes sense for the CiviCRM project team.
What I'm trying to figure out is if my time is better spent trying to remove 1MB from the official, english only CiviCRM release OR just create a mirror without the redundant libraries of the multilingual release so that anyone could package into a distribution.
What would make the decision easy would be if the whitelist isn't able to target a specific release. If the 4.1.3, english-only release is < 10MB, would I be able to add just http://sourceforge.net/projects/civicrm/files/civicrm-stable/4.1.3/civicrm-4.1.3-drupal.tar.gz?
Would that require summiting a new whitelist item for 4.1.4, 4.1.5, etc?
If it does, the mirror route seem more attractive. The 4.1.2 i10n release is 14MB, but I think that can be trimmed down to < 10MB by removing...
Then I would just need a patch to redirect these to their Drupal paths. This is the direction I'm leaning, but then I would need to update the mirror with every CiviCRM release. Still probably less time consuming than requesting each release of CiviCRM be whitelisted and more useful to more people.
Comment #3
geerlingguy commentedGoing by the official guidelines, yes, we would need to create a new whitelist entry for every version... however, with a little regex-fu, we could probably set something up to only allow versions beyond 4.1.2, which would make that a moot point.
I'll leave this postponed until the archive is < 10 MB, and then we can work on making it work for 4.1.3 (or whatever version meets our guidelines) and later.
Comment #4
kreynen commentedok... for the short term, I'm going to go the mirror route and use that to make slimming down future releases a priority. Even if I was able to get the english-only 4.1.3 to squeak in under 10MB, it wouldn't take much to bump it back up. Since I have no idea what's on the CiviCRM roadmap that may effect the size of the release, a -min mirror seems like the better option for now.
Comment #5
geerlingguy commentedDefinitely. It'd be nice if the CiviCRM project could themselves include some sort of -min package that didn't include a ton of libraries anyways (imo).
Comment #6
kreynen commentedAgreed, but changing that is going to take time.
At least CiviCRM is moving towards fully adopting Drupal's coding standards. The previous, modified variation of the standard that allowed CamelCase for function and variable names always made my eyes bleed.
Here's the gihub mirror...
repo - https://github.com/kreynen/civicrm-min
license - https://github.com/kreynen/civicrm-min/blob/master/agpl-3.0.txt
Because GitHub's zip compression isn't nearly as good as SourceForge (or whatever the CiviCRM team uses before uploading... I don't really remember how SourceForge works), I had to remove more than I expected. As a result I'm going to be making requests to add the following GPL libraries as well; KCFinder, phpids, tcpdf, and dompdf.
I'll open separate issues for each of those.
Comment #7
kreynen commentedComment #8
geerlingguy commentedAdded: http://drupal.org/node/1592986
Would like to use the official CiviCRM downloads someday, though, so keep campaigning for that :)
Comment #9
kreynen commentedDiscussion with CiviCRM community about an official, minimized version going well.
http://forum.civicrm.org/index.php/topic,24752.0.html
Comment #10
kreynen commentedNot sure what the process is for changing a whitelist entry or if that's happened yet. There are no files available yet, but when 4.2 is released there will be a version of CiviCRM without dompdf, IDS, jquery, ckeditor, tinymce and joomla and wordpress directories available at http://downloads.civicrm.org/civicrm-4.2.0.starterkit.tgz. According to @lobo, the size will be 7.5MB. That should leave plenty of space if they add another library in the future. As soon as a whitelisted download is available, I will update http://drupal.org/project/cm_starterkit_moderate and http://drupal.org/project/civicrm_starterkit. I believe those are the only distributions using my minimized github version, but do you have a way to check the .make files to confirm that?
Once the starterkits including CiviCRM are repackaged, [#1592986] and can removed.
The status on CiviCRM side can be tracked here http://issues.civicrm.org/jira/browse/CRM-10299
If you want me to do something other than update this issue when http://downloads.civicrm.org/civicrm-4.2.0.starterkit.tgz is available, let me know.
Comment #11
geerlingguy commentedJust post an update when something happens, and point me to the new download link :)
Comment #12
lobo commentedI will update this issue when we have 4.2.alpha1 available along with the exact URL :)
Most likely this will happen on wed or thu of this week
lobo
Comment #13
kreynen commentedAs noted in http://issues.civicrm.org/jira/browse/CRM-10299, the official minimized download of CiviCRM is now available at http://downloads.civicrm.org/civicrm-4.2.beta2-starterkit.tgz. This was created using the CiviCRM's packaging scripts to releases after beta2 of 4.2 will also be available. Please work your regex magic to download make any release that follow this pattern http://downloads.civicrm.org/civicrm-[version]-starterkit.tgz available for packaging on Drupal.org.
Please replace the github mirror with the new 4.2 download. I'll update both http://drupal.org/project/cm_starterkit_moderate and http://drupal.org/project/civicrm_starterkit as soon as this is done.
@geerlingguy Thanks again for your help with this!
Comment #14
geerlingguy commentedWhere would one normally download this starterkit? I can only see a bunch of other downloads on the SourceForge page (http://sourceforge.net/projects/civicrm/files/civicrm-latest/4.2.beta2/), and I was just trying to make sure I add all the right regexes in the whitelist entry...
I have
^http://downloads\.civicrm\.org/civicrm-.+-starterkit.tgz$so far.Comment #15
kreynen commentedThe starter kit version of the download is new, but on't be listed with the other downloads on sourceforge since it requires replacing several libraries.
Comment #16
kreynen commentedThis was being discussed in #1589204: Please Whitelist DOMPDF, but dompdf appears to be validating now and only civicrm still fails I'm moving it to this issue.
Comment #17
geerlingguy commentedOkay, I've added the whitelist entry: http://drupal.org/node/1695056 - as long as they follow the same pattern, with -starterkit.tgz on the end, it should work (this should make it so people can only use the smaller starterkit, and not other, larger distributions of CiviCRM.
Comment #18
kreynen commentedStill failing. Is there a delay between when you make those changes and when I'd be able to force packaging by tagging a new release?
Comment #19
kreynen commentedworking now :)
Comment #21
kreynen commentedWhen the official minimize CiviCRM package was add, my github mirror should have been removed from the whitelist
http://drupal.org/node/1592986
Comment #22
geerlingguy commentedWhoops! Thanks for catching that; it's been deleted.
Comment #24
kreynen commentedComment #25
gisleI am cleaning up all the old "Needs review" entries to make the issue queue less messy. This hasn't been touched in 5 years. Don't see any problems with this and moving to "Fixed". Anyone objecting have two weeks to reopen before is is automatically closed.