I'll work on this one, as I'm already adding a PSR-0-ified test in #890790: deleting nodes does not delete their comments. and had to convert CommentHelperCase to PSR-0 as well over there.

CommentFileSizeAuthor
#32 1588284-comment-tests-psr0-32.patch183.04 KBaspilicious
#31 1588284-comment-tests-psr0-21.patch179.99 KBrobloach
#23 1588284-comment-tests-psr0-23.patch179.95 KBTor Arne Thune
#23 interdiff-1588284-21-23.txt449 bytesTor Arne Thune
#21 1588284-comment-tests-psr0-21.patch179.99 KBTor Arne Thune
#16 1588284-comment-tests-psr0-16.patch198.92 KBTor Arne Thune
#16 interdiff-1588284-12-16.txt5.78 KBTor Arne Thune
#12 1588284-comment-tests-psr0-12.patch199.48 KBTor Arne Thune
#12 interdiff-1588284-10-12.txt3.08 KBTor Arne Thune
#10 1588284-comment-tests-psr0-10.patch199.68 KBTor Arne Thune
#10 interdiff-1588284-3-10.txt895 bytesTor Arne Thune
#2 1588284-comment-tests-psr0-3.patch202.28 KBaspilicious

Comments

Tor Arne Thune’s picture

Tor Arne Thune commented
Assigned: Tor Arne Thune » Unassigned

Unassigning, as aspilicious beat me to it ;)

aspilicious’s picture

aspilicious commented
Status: Active » Needs review
StatusFileSize
new 1588284-comment-tests-psr0-3.patch202.28 KB

This normally should be green.

Tor Arne Thune’s picture

Tor Arne Thune commented
Status: Needs review » Needs work 
+++ b/core/modules/comment/lib/Drupal/comment/Tests/CommentThreadingTest.phpundefined
@@ -0,0 +1,106 @@
+//use Drupal\comment\Comment;

Leftover I suppose.

Also there is a place in user.test that references CommentHelperCase in the comments, so that should be changed.

grep -rl "CommentHelperCase" .
./core/modules/rdf/rdf.test
./core/modules/user/user.test
aspilicious’s picture

aspilicious commented

But the other issue should fix that, so I'm leaving the reroll to you when the other issue is fixed :)

Tor Arne Thune’s picture

Tor Arne Thune commented

Sure thing *writes a Post-It*

aspilicious’s picture

aspilicious commented

And you should try to fix the warnings ;).
And those fails are rly weird, looks like a random bot failure :s

Tor Arne Thune’s picture

Tor Arne Thune commented
Status: Needs work » Needs review
Issue tags: -PSR-0

#2: 1588284-comment-tests-psr0-3.patch queued for re-testing.

Let's try a re-test. Maybe a random test failure again.

Status: Needs review » Needs work
Issue tags: +PSR-0

The last submitted patch, 1588284-comment-tests-psr0-3.patch, failed testing.

Tor Arne Thune’s picture

Tor Arne Thune commented
Assigned: Unassigned » Tor Arne Thune

Okay, will deal with this later.

Tor Arne Thune’s picture

Tor Arne Thune commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-1588284-3-10.txt895 bytes
new 1588284-comment-tests-psr0-10.patch199.68 KB

Status: Needs review » Needs work

The last submitted patch, 1588284-comment-tests-psr0-10.patch, failed testing.

Tor Arne Thune’s picture

Tor Arne Thune commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-1588284-10-12.txt3.08 KB
new 1588284-comment-tests-psr0-12.patch199.48 KB

Removing unneeded use statements. Still have no clue about the failing upgrade tests.

Tor Arne Thune’s picture

Tor Arne Thune commented

Oh, so the upgrade test failures were random bot failures. Great!

aspilicious’s picture

aspilicious commented

Actually that is'nt great. I think it's related to these psr-0 patches and a not cleared registry when upgrading. Hard to track down if it's random

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work 
+++ b/core/modules/comment/lib/Drupal/comment/Tests/CommentActionsTest.phpundefined
@@ -0,0 +1,79 @@
+
+namespace Drupal\comment\Tests;
+
+use Drupal\comment\Tests\CommentTestBase;

The use shouldn't be necessary because we're in the same namespace.

Powered by Dreditor.

Tor Arne Thune’s picture

Tor Arne Thune commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-1588284-12-16.txt5.78 KB
new 1588284-comment-tests-psr0-16.patch198.92 KB

Makes sense.

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

Looks good now

aspilicious’s picture

aspilicious commented
Status: Reviewed & tested by the community » Postponed

But I'm going to postpone this on the other issue.

aspilicious’s picture

aspilicious commented
Status: Postponed » Needs work

I'll leave this one for you Tor Arne Thune :)

Tor Arne Thune’s picture

Tor Arne Thune commented

Thanks, will re-roll it today :)

Tor Arne Thune’s picture

Tor Arne Thune commented
Status: Needs work » Needs review
StatusFileSize
new 1588284-comment-tests-psr0-21.patch179.99 KB

This one should be good. Also changed CommentRSSTest to CommentRssTest (and its method to testCommentRss()) See #1591436: Convert filter tests to PSR-0 (comment #7) for the why.

aspilicious’s picture

aspilicious commented
Status: Needs review » Needs work 
+++ b/core/modules/comment/lib/Drupal/comment/Tests/CommentNodeAccessTest.phpundefined
@@ -0,0 +1,79 @@
+/**
+ * @file
+ * Definition of Drupal\comment\Tests\CommentNodeAccessTest.
+ */
+
+namespace Drupal\comment\Tests;
+
+use Drupal\simpletest\WebTestBase;

Use webtestbase isn't needed here

7 days to next Drupal core point release.

Tor Arne Thune’s picture

Tor Arne Thune commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-1588284-21-23.txt449 bytes
new 1588284-comment-tests-psr0-23.patch179.95 KB

Removed.

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

Gogogogo!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1588284-comment-tests-psr0-23.patch, failed testing.

Tor Arne Thune’s picture

Tor Arne Thune commented
Status: Needs work » Reviewed & tested by the community

Looks like it's needed as setUp() calls WebTestBase::setUp() directly.
Shall we say #21 is RTBC?

Tor Arne Thune’s picture

Tor Arne Thune commented
Status: Reviewed & tested by the community » Needs review

Oops, cross-post with System Message.

aspilicious’s picture

aspilicious commented

That doesn't sound ok...

I remember an issue about this....

Tor Arne Thune’s picture

Tor Arne Thune commented

Yes, there is an issue, but can't find it. I think we should leave that for the other issue.

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

RTBC #21, we'll see what gets in first

robloach’s picture

robloach
he/him
commented
StatusFileSize
new 1588284-comment-tests-psr0-21.patch179.99 KB

Re-uploading #21 to keep confusion down.

aspilicious’s picture

aspilicious commented
StatusFileSize
new 1588284-comment-tests-psr0-32.patch183.04 KB

Reroll!

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.