weather_retrieve_data() gives a PHP notice if it wasn't able to get a valid response from drupal_http_request(). Patch checks that $response->data has value.

CommentFileSizeAuthor
weather-weather_retrieve_data-notices.patch685 bytesles lim

Comments

Status: Needs review » Needs work

The last submitted patch, weather-weather_retrieve_data-notices.patch, failed testing.

les lim’s picture

les lim
he/they
Primary language English
commented
Assigned: les lim » Unassigned

There shouldn't be any reason this patch should affect the outcome of that test. Perhaps the test is broken?

toddy’s picture

toddy commented
Assigned: Unassigned » toddy
Status: Needs work » Needs review

Yes, the parser test had an issue with daytime and nighttime calculation. The tested station is too far in the north, so now (during summer on the northern hemisphere) the daylight calculation returns correctly "day", while the test (being written in winter) expected night. This should be fixed now, I'm requeuing your patch for testing.

Apart from that, I've applied your patch, many thanks for that. It'll be part of the next release.

toddy’s picture

toddy commented

weather-weather_retrieve_data-notices.patch queued for re-testing.

toddy’s picture

toddy commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.