Currently the Apache Solr Stats module correctly calculates facet usage, however leveraging the API functions provided by Facet API will calculate the facet usage more reliably as well as eliminate the need for the apachesolr_stats_determine_field_from_query() function.

CommentFileSizeAuthor
#4 facet-usage-1588906-4.patch3.06 KBcpliakas
#1 facet-usage-1588906-1.patch3.06 KBcpliakas

Comments

cpliakas’s picture

cpliakas commented
StatusFileSize
new facet-usage-1588906-1.patch3.06 KB

The attached patch makes the changes proposed in the original post.

One important thing to note, it seems like some unused data is stored in the "filters" field, specifically the #exclude and #local properties. The patch actually changes how the data is stored so that it is an associative array of facet name / facet values. This change would effect anyone who is using the 7.x-1.x version of Apache Solr Statistics, so I am not sure how you want to handle this. As an alternative, the return value of the proposed apachesolr_stats_get_active_facets() API function could mimc the current data structure to ensure backwards compatibility.

Let me know how you want to proceed,
Chris

cpliakas’s picture

cpliakas commented
Status: Active » Needs review

Changing to "needs review".

cpliakas’s picture

cpliakas commented
Title: Leverage API functions in the Facet API module to more reliable calculate facet usage » Leverage API functions in the Facet API module to calculate facet usage more reliably

Changing grammar of title.

cpliakas’s picture

cpliakas commented
StatusFileSize
new facet-usage-1588906-4.patch3.06 KB

Rerolled patch against latest 7.x-1.x code.

cpliakas’s picture

cpliakas commented
Status: Needs review » Fixed

Added in commit http://drupalcode.org/project/apachesolr_stats.git/commit/d187bbf.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.