#1454682: Allow cas_logout() to be called from hook_user_logout() introduced helpful documentation for the new capabilities of cas_logout(). However, the code comment for the Drupal 6 version included hook_user_logout() and hook_module_implements_alter() which do not exist for Drupal 6. Patch following.

CommentFileSizeAuthor
#1 cas-logout-comment-change-1589078-1.patch835 bytesbneil

Comments

bneil’s picture

bneil commented
Status: Active » Needs review
StatusFileSize
new cas-logout-comment-change-1589078-1.patch835 bytes

I changed hook_user_logout() to hook_user(). I also eliminated the line about hook_module_implements_alter() since it doesn't exist in Drupal 6.

bfroehle’s picture

bfroehle commented
Status: Needs review » Fixed

Thanks! I took your patch, but called it hook_user('logout') instead of just hook_user(). There is precedent for convention: see user_external_login() for example.

Committed to 6.x-3.x.

bneil’s picture

bneil commented

Thanks! That makes sense.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.