When running cron right after installing the module, an undefined variable error is thrown because the "time_now" variable is defined inside of the database record retrieval loop.

CommentFileSizeAuthor
#1 time-now-1589262-1.patch2.55 KBcpliakas

Comments

cpliakas’s picture

cpliakas commented
Status: Needs review » Active
StatusFileSize
new time-now-1589262-1.patch2.55 KB

The attached patch utilizes the REQUEST_TIME constant to eliminate calling the time() function, which also fixes the undefined index error.

cpliakas’s picture

cpliakas commented
Status: Active » Needs review

Marking as needs review...

tcmug’s picture

tcmug commented
Status: Active » Needs review

Hey, good catch!

I quickly reviewed it and it doesn't seem to break anything - at least when running cron from drush. Pushed to repo.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Fixed

Fixed here http://drupalcode.org/project/radioactivity.git/commit/51ef8f0

Any reason to keep this open? I assume not so marking fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.