If you set theme as anonymous, then login, user cant change theme [#1589436]

Hi,

this is great module, but i found out a bug: if you change theme as anonymous, theme name is stored into $_SESSION['custom_theme'].
If you then login $_SESSION['custom_theme'] is still stored and switchtheme module loads theme name from session not from $user->theme. So we need to prefer value $user->theme instead $_SESSION['custom_theme'].

Patch is simply (in dev version) :
118 row switchtheme.module
- if (isset($_SESSION['custom_theme'])) {
+ if (empty($user->theme) && isset($_SESSION['custom_theme'])) {

If you confirm this, it could be added to dev module.

Comment	File	Size	Author
#1	switchtheme-authenticated-fix-1589436.patch	562 bytes	bradwade

Comments

Comment #1

bradwade commented 15 June 2012 at 20:14

Status:

Patch (to be ported)

» Needs review

Status	File	Size
new	switchtheme-authenticated-fix-1589436.patch	562 bytes

The above changed worked for me. Here is a patch for it from the 1.0 tag.

Comment #2

dgale commented 9 September 2012 at 17:49

This same bug exists in the 6.x version of the code, including the latest dev.

The same fix works to correct the problem. The only difference is the problem is at line 84 in switchtheme.module:

- if (isset($_SESSION['custom_theme']) && (!isset($custom_theme) || $custom_theme === '0')) {
+ if (empty($user->theme) && isset($_SESSION['custom_theme']) && (!isset($custom_theme) || $custom_theme === '0')) {