d.o turned all of us into CTRL+A and CTRL+C monkeys. Fix that.

CommentFileSizeAuthor
#1 dreditor.form-backup.1.patch2.08 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Fixed
StatusFileSize
new dreditor.form-backup.1.patch2.08 KB

Committed attached patch.

Bojhan’s picture

Bojhan commented

Awesome, although it could probably sound less technical/scary: "Restore previously entered information/data" and wouldn't even bother with the confirmation button (but that's just me, hating confirmation buttons all round).

Grayside’s picture

Grayside commented

There are several good browser plugins in this space. You sure you want to maintain it here? Better to document best of breed on project page i think.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

@Grayside: As the code documents, most browsers implement this natively. But drupal.org manages to totally hi-jack that. Did you battle-test those browser plugins against random d.o weirdnesses?

Grayside’s picture

Grayside commented

No I did not. I just went by reading the issue and thinking about my installed plugins. For posts I care about I stopped typing directly into browsers some time ago, so I might not have noticed my plugins not working. Will try it out later.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

moshe weitzman’s picture

moshe weitzman commented

FYI, the most recent data loss I had was arguably dreditors fault. I was not logged in and it still let me Review a patch. At the end of the Review, it had no textarea to paste into. I had to pull my review out of the DOM using Chrome Inspector!

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Hm. That's slightly different; thought we fixed that long ago already - re-opened #1040844: Potential data loss when not logged in (and doing reviews that cannot be posted afterwards)