I still think we should kill dashboard, but whatevah...

Patch coming soon, see also #1513210: Meta: Start converting module provided classes to PSR-0

CommentFileSizeAuthor
#1 1591334-dashboard-tests-1.patch16.65 KBaspilicious

Comments

aspilicious’s picture

Status: Active » Needs review
StatusFileSize
new16.65 KB
aspilicious’s picture

Issue tags: +PSR-0
Tor Arne Thune’s picture

Status: Needs review » Reviewed & tested by the community

Straight-forward and @file docblocks look correct.

chx’s picture

Status: Reviewed & tested by the community » Needs review

I am not sure but I think these are fairly bad. We are destroying the test git histories completely. Did we already did this with every single class we converted? I mostly stayed out of PSR-0 issues alas because I thought it's an asinine standard we shouldn't use but obviously we no longer care about what's technically right but about what others do and I promised to go along so yeah, let's go PSR-0 but at least let's not destroy git blame along the way, OK?

Tor Arne Thune’s picture

What is the alternative solution?

chx’s picture

I asked #drupal-gitsupport to help. Until someone with git-fu shows up I think it's

git checkout -b issue-1591334 8.x
git mv foo bar
git commit -am 'Moved stuff'
git format-patch -C -M --stdout 8.x > patchname.patch

Edited based on http://groups.drupal.org/node/141529

chx’s picture

Status: Needs review » Reviewed & tested by the community

Apparently I am wrong. Nevermind! git blame can follow history over this, it tracks content.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Yeah git should track these patches fine I think.

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.