I still think we should kill dashboard, but whatevah...
Patch coming soon, see also #1513210: Meta: Start converting module provided classes to PSR-0
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 1591334-dashboard-tests-1.patch | 16.65 KB | aspilicious |
I still think we should kill dashboard, but whatevah...
Patch coming soon, see also #1513210: Meta: Start converting module provided classes to PSR-0
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 1591334-dashboard-tests-1.patch | 16.65 KB | aspilicious |
Comments
Comment #1
aspilicious commentedComment #2
aspilicious commentedComment #3
Tor Arne Thune commentedStraight-forward and @file docblocks look correct.
Comment #4
chx commentedI am not sure but I think these are fairly bad. We are destroying the test git histories completely. Did we already did this with every single class we converted? I mostly stayed out of PSR-0 issues alas because I thought it's an asinine standard we shouldn't use but obviously we no longer care about what's technically right but about what others do and I promised to go along so yeah, let's go PSR-0 but at least let's not destroy git blame along the way, OK?
Comment #5
Tor Arne Thune commentedWhat is the alternative solution?
Comment #6
chx commentedI asked #drupal-gitsupport to help. Until someone with git-fu shows up I think it's
Edited based on http://groups.drupal.org/node/141529
Comment #7
chx commentedApparently I am wrong. Nevermind! git blame can follow history over this, it tracks content.
Comment #8
catchYeah git should track these patches fine I think.
Committed/pushed to 8.x, thanks!