_media_save_file_permenently(&$file) should be _media_save_file_permanently($file)

- permenently isn't a valid english word (unless I'm wrong here, not a native english speaker)
- file is an object so the reference is not needed

patch coming up in seconds

CommentFileSizeAuthor
#5 1591534-5.patch1.28 KBswentel
#1 1591534-1.patch1.32 KBswentel

Comments

swentel’s picture

swentel commented
Status: Active » Needs review
StatusFileSize
new 1591534-1.patch1.32 KB

Patch attached

swentel’s picture

swentel commented
Title: permenently vs permantly » permenently vs permanently

Oh dear, didn't even get the issue title right.

aaron’s picture

aaron commented
Status: Needs review » Reviewed & tested by the community

this is good. Thanks for the catch. I don't see any other usages in there so I am marking this as rtbc.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Version: 7.x-2.x-dev » 7.x-1.x-dev

We're getting rid of this function in 7.x-2.x. Let's see if this applies for 1.x.

swentel’s picture

swentel commented
StatusFileSize
new 1591534-5.patch1.28 KB

Doesn't apply, new patch for 7.x-1.x branch.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Reviewed & tested by the community » Fixed

Thanks! Committed to 7.x-1.x: http://drupalcode.org/project/media.git/commit/230be2d

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.