The attached patch cleans up the install file for feeds_excel. I got somewhat confused when trying to enable this module, because I downloaded the required library, but it kept telling me it wasn't there. I finally realized that the fall-back path in the requirements check was misspelled as "libaries" and was going to submit a patch to fix that. However, since the module can't be enabled without the libraries API being present, I don't see the point in having the fallback at all.

CommentFileSizeAuthor
feeds_excel-remove_libraries_fallback.patch524 bytesacrollet

Comments

SebCorbin’s picture

SebCorbin commented

I would be glad to have the fallback path though, another module installed is a slower Drupal.

Patch is ok, although the code above this line is totally pointless because there's already a strong dependency in the .info file http://drupalcode.org/project/feeds_excel.git/blob/refs/heads/7.x-1.x:/f...

derhasi’s picture

derhasi commented
Status: Active » Fixed

Fixed by d755459.

@SebCorbin, as the libraries module is a common one for dealing with libraries, and it isn't really a big one, the dependency will stay ;)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.